* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
@ 2010-12-28 11:26 Inki Dae
2010-12-29 0:50 ` Kukjin Kim
2010-12-29 1:03 ` Kukjin Kim
0 siblings, 2 replies; 7+ messages in thread
From: Inki Dae @ 2010-12-28 11:26 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
arch/arm/mach-s5pv210/include/mach/regs-clock.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
index ebaabe0..09680d9 100644
--- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
+++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
@@ -146,6 +146,7 @@
#define S5P_OM_STAT S5P_CLKREG(0xE100)
#define S5P_USB_PHY_CONTROL S5P_CLKREG(0xE80C)
#define S5P_DAC_CONTROL S5P_CLKREG(0xE810)
+#define S5P_MIPI_DPHY_CONTROL S5P_CLKREG(0xE814)
#define S5P_INFORM0 S5P_CLKREG(0xF000)
#define S5P_INFORM1 S5P_CLKREG(0xF004)
@@ -196,7 +197,10 @@
#define S5P_OTHERS_USB_SIG_MASK (1 << 16)
/* MIPI */
-#define S5P_MIPI_DPHY_EN (3)
+#define S5P_MIPI_DPHY_EN (3 << 0)
+
+/* S5P_MIPI_PHY_CON0 */
+#define S5P_MIPI_M_RESETN (1 << 1)
/* S5P_DAC_CONTROL */
#define S5P_DAC_ENABLE (1)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-28 11:26 [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions Inki Dae
@ 2010-12-29 0:50 ` Kukjin Kim
2010-12-30 1:23 ` InKi Dae
2010-12-29 1:03 ` Kukjin Kim
1 sibling, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2010-12-29 0:50 UTC (permalink / raw)
To: linux-arm-kernel
Inki Dae wrote:
>
Please keep myself in Cc on this. I already noticed that to you before.
I think you should check whether mail loop is suitable or not...
And would be better if you could add #0 patch to understand your patches.
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
> arch/arm/mach-s5pv210/include/mach/regs-clock.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
b/arch/arm/mach-
> s5pv210/include/mach/regs-clock.h
> index ebaabe0..09680d9 100644
> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> @@ -146,6 +146,7 @@
> #define S5P_OM_STAT S5P_CLKREG(0xE100)
> #define S5P_USB_PHY_CONTROL S5P_CLKREG(0xE80C)
> #define S5P_DAC_CONTROL S5P_CLKREG(0xE810)
> +#define S5P_MIPI_DPHY_CONTROL S5P_CLKREG(0xE814)
>
> #define S5P_INFORM0 S5P_CLKREG(0xF000)
> #define S5P_INFORM1 S5P_CLKREG(0xF004)
> @@ -196,7 +197,10 @@
> #define S5P_OTHERS_USB_SIG_MASK (1 << 16)
>
> /* MIPI */
> -#define S5P_MIPI_DPHY_EN (3)
> +#define S5P_MIPI_DPHY_EN (3 << 0)
> +
> +/* S5P_MIPI_PHY_CON0 */
> +#define S5P_MIPI_M_RESETN (1 << 1)
>
> /* S5P_DAC_CONTROL */
> #define S5P_DAC_ENABLE (1)
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-29 0:50 ` Kukjin Kim
@ 2010-12-30 1:23 ` InKi Dae
0 siblings, 0 replies; 7+ messages in thread
From: InKi Dae @ 2010-12-30 1:23 UTC (permalink / raw)
To: linux-arm-kernel
Hello, Mr. Kukjin.
I am on vacation until this sunday.
Could you please give me your reviews?
If you give me your comments about my patch series then I will re-work
them on Monday.
by doing so, we could save the time.
thank you.
2010/12/29 Kukjin Kim <kgene.kim@samsung.com>:
> Inki Dae wrote:
>>
> Please keep myself in Cc on this. I already noticed that to you before.
> I think you should check whether mail loop is suitable or not...
>
> And would be better if you could add #0 patch to understand your patches.
>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>> ?arch/arm/mach-s5pv210/include/mach/regs-clock.h | ? ?6 +++++-
>> ?1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> b/arch/arm/mach-
>> s5pv210/include/mach/regs-clock.h
>> index ebaabe0..09680d9 100644
>> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
>> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
>> @@ -146,6 +146,7 @@
>> ?#define S5P_OM_STAT ? ? ? ? ?S5P_CLKREG(0xE100)
>> ?#define S5P_USB_PHY_CONTROL ?S5P_CLKREG(0xE80C)
>> ?#define S5P_DAC_CONTROL ? ? ? ? ? ? ?S5P_CLKREG(0xE810)
>> +#define S5P_MIPI_DPHY_CONTROL ? ? ? ? ? ? ? ?S5P_CLKREG(0xE814)
>>
>> ?#define S5P_INFORM0 ? ? ? ? ?S5P_CLKREG(0xF000)
>> ?#define S5P_INFORM1 ? ? ? ? ?S5P_CLKREG(0xF004)
>> @@ -196,7 +197,10 @@
>> ?#define S5P_OTHERS_USB_SIG_MASK ? ? ? ? ? ? ?(1 << 16)
>>
>> ?/* MIPI */
>> -#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3)
>> +#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3 << 0)
>> +
>> +/* S5P_MIPI_PHY_CON0 */
>> +#define S5P_MIPI_M_RESETN ? ? ? ? ? ?(1 << 1)
>>
>> ?/* S5P_DAC_CONTROL */
>> ?#define S5P_DAC_ENABLE ? ? ? ? ? ? ? ? ? ? ? (1)
>> --
>
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-28 11:26 [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions Inki Dae
2010-12-29 0:50 ` Kukjin Kim
@ 2010-12-29 1:03 ` Kukjin Kim
2010-12-29 1:45 ` Kyungmin Park
1 sibling, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2010-12-29 1:03 UTC (permalink / raw)
To: linux-arm-kernel
Inki Dae wrote:
>
One more comment.
Please work on S5P SoCs based on maintainer's latest for-next.
You can find the reason in below.
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
> arch/arm/mach-s5pv210/include/mach/regs-clock.h | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
b/arch/arm/mach-
> s5pv210/include/mach/regs-clock.h
> index ebaabe0..09680d9 100644
> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> @@ -146,6 +146,7 @@
> #define S5P_OM_STAT S5P_CLKREG(0xE100)
> #define S5P_USB_PHY_CONTROL S5P_CLKREG(0xE80C)
> #define S5P_DAC_CONTROL S5P_CLKREG(0xE810)
> +#define S5P_MIPI_DPHY_CONTROL S5P_CLKREG(0xE814)
>
Already added by Sylwester's patch.
> #define S5P_INFORM0 S5P_CLKREG(0xF000)
> #define S5P_INFORM1 S5P_CLKREG(0xF004)
> @@ -196,7 +197,10 @@
> #define S5P_OTHERS_USB_SIG_MASK (1 << 16)
>
> /* MIPI */
> -#define S5P_MIPI_DPHY_EN (3)
Oops, already removed because not used anywhere at that time.
> +#define S5P_MIPI_DPHY_EN (3 << 0)
> +
> +/* S5P_MIPI_PHY_CON0 */
> +#define S5P_MIPI_M_RESETN (1 << 1)
>
> /* S5P_DAC_CONTROL */
> #define S5P_DAC_ENABLE (1)
> --
Please re-work your all patches.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-29 1:03 ` Kukjin Kim
@ 2010-12-29 1:45 ` Kyungmin Park
2010-12-29 2:07 ` Kukjin Kim
0 siblings, 1 reply; 7+ messages in thread
From: Kyungmin Park @ 2010-12-29 1:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 29, 2010 at 10:03 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Inki Dae wrote:
>>
> One more comment.
>
> Please work on S5P SoCs based on maintainer's latest for-next.
> You can find the reason in below.
>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>> ?arch/arm/mach-s5pv210/include/mach/regs-clock.h | ? ?6 +++++-
>> ?1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
> b/arch/arm/mach-
>> s5pv210/include/mach/regs-clock.h
>> index ebaabe0..09680d9 100644
>> --- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
>> +++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h
>> @@ -146,6 +146,7 @@
>> ?#define S5P_OM_STAT ? ? ? ? ?S5P_CLKREG(0xE100)
>> ?#define S5P_USB_PHY_CONTROL ?S5P_CLKREG(0xE80C)
>> ?#define S5P_DAC_CONTROL ? ? ? ? ? ? ?S5P_CLKREG(0xE810)
>> +#define S5P_MIPI_DPHY_CONTROL ? ? ? ? ? ? ? ?S5P_CLKREG(0xE814)
>>
> Already added by Sylwester's patch.
>
>> ?#define S5P_INFORM0 ? ? ? ? ?S5P_CLKREG(0xF000)
>> ?#define S5P_INFORM1 ? ? ? ? ?S5P_CLKREG(0xF004)
>> @@ -196,7 +197,10 @@
>> ?#define S5P_OTHERS_USB_SIG_MASK ? ? ? ? ? ? ?(1 << 16)
>>
>> ?/* MIPI */
>> -#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3)
>
> Oops, already removed because not used anywhere at that time.
>
>> +#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3 << 0)
>> +
>> +/* S5P_MIPI_PHY_CON0 */
>> +#define S5P_MIPI_M_RESETN ? ? ? ? ? ?(1 << 1)
>>
>> ?/* S5P_DAC_CONTROL */
>> ?#define S5P_DAC_ENABLE ? ? ? ? ? ? ? ? ? ? ? (1)
>> --
>
> Please re-work your all patches.
Before re-work, give technical comments instead of patch submit.
You mean others are looks good except these one?
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-29 1:45 ` Kyungmin Park
@ 2010-12-29 2:07 ` Kukjin Kim
2010-12-29 2:24 ` Kyungmin Park
0 siblings, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2010-12-29 2:07 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> On Wed, Dec 29, 2010 at 10:03 AM, Kukjin Kim <kgene.kim@samsung.com>
wrote:
> > Inki Dae wrote:
> >>
> > One more comment.
> >
> > Please work on S5P SoCs based on maintainer's latest for-next.
> > You can find the reason in below.
(snip)
> > Please re-work your all patches.
>
> Before re-work, give technical comments instead of patch submit.
> You mean others are looks good except these one?
>
No. not read yet.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions.
2010-12-29 2:07 ` Kukjin Kim
@ 2010-12-29 2:24 ` Kyungmin Park
0 siblings, 0 replies; 7+ messages in thread
From: Kyungmin Park @ 2010-12-29 2:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 29, 2010 at 11:07 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> On Wed, Dec 29, 2010 at 10:03 AM, Kukjin Kim <kgene.kim@samsung.com>
> wrote:
>> > Inki Dae wrote:
>> >>
>> > One more comment.
>> >
>> > Please work on S5P SoCs based on maintainer's latest for-next.
>> > You can find the reason in below.
>
> (snip)
>
>> > Please re-work your all patches.
>>
>> Before re-work, give technical comments instead of patch submit.
>> You mean others are looks good except these one?
>>
> No. not read yet.
Don't make a duplicated work. then give whole reviews and request it
send it again.
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-12-30 1:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-28 11:26 [PATCH 1/5] S5PC110: add MIPI-DSI system register definitions Inki Dae
2010-12-29 0:50 ` Kukjin Kim
2010-12-30 1:23 ` InKi Dae
2010-12-29 1:03 ` Kukjin Kim
2010-12-29 1:45 ` Kyungmin Park
2010-12-29 2:07 ` Kukjin Kim
2010-12-29 2:24 ` Kyungmin Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox