From: jg1.han@samsung.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG
Date: Tue, 09 Oct 2012 17:34:59 +0900 [thread overview]
Message-ID: <003b01cda5f8$f84e35c0$e8eaa140$%han@samsung.com> (raw)
In-Reply-To: <1349443590-29901-1-git-send-email-gautam.vivek@samsung.com>
On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote
>
> EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
> system register (base addr + 0x230). It's wrongly placed in regs-pmu.
> Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
As you mentioned, this definition is wrong.
So, it should be removed.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/regs-pmu.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> index d4e392b..70b2795 100644
> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> @@ -230,8 +230,6 @@
>
> /* For EXYNOS5 */
>
> -#define EXYNOS5_USB_CFG S5P_PMUREG(0x0230)
> -
> #define EXYNOS5_AUTO_WDTRESET_DISABLE S5P_PMUREG(0x0408)
> #define EXYNOS5_MASK_WDTRESET_REQUEST S5P_PMUREG(0x040C)
>
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-09 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 13:26 [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG Vivek Gautam
2012-10-09 8:34 ` Jingoo Han [this message]
2012-10-31 5:47 ` Vivek Gautam
2012-11-08 4:52 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003b01cda5f8$f84e35c0$e8eaa140$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).