* [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG
@ 2012-10-05 13:26 Vivek Gautam
2012-10-09 8:34 ` Jingoo Han
0 siblings, 1 reply; 4+ messages in thread
From: Vivek Gautam @ 2012-10-05 13:26 UTC (permalink / raw)
To: linux-arm-kernel
EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
system register (base addr + 0x230). It's wrongly placed in regs-pmu.
Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
arch/arm/mach-exynos/include/mach/regs-pmu.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
index d4e392b..70b2795 100644
--- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
+++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
@@ -230,8 +230,6 @@
/* For EXYNOS5 */
-#define EXYNOS5_USB_CFG S5P_PMUREG(0x0230)
-
#define EXYNOS5_AUTO_WDTRESET_DISABLE S5P_PMUREG(0x0408)
#define EXYNOS5_MASK_WDTRESET_REQUEST S5P_PMUREG(0x040C)
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG
2012-10-05 13:26 [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG Vivek Gautam
@ 2012-10-09 8:34 ` Jingoo Han
2012-10-31 5:47 ` Vivek Gautam
2012-11-08 4:52 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Jingoo Han @ 2012-10-09 8:34 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote
>
> EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
> system register (base addr + 0x230). It's wrongly placed in regs-pmu.
> Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
As you mentioned, this definition is wrong.
So, it should be removed.
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> ---
> arch/arm/mach-exynos/include/mach/regs-pmu.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> index d4e392b..70b2795 100644
> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
> @@ -230,8 +230,6 @@
>
> /* For EXYNOS5 */
>
> -#define EXYNOS5_USB_CFG S5P_PMUREG(0x0230)
> -
> #define EXYNOS5_AUTO_WDTRESET_DISABLE S5P_PMUREG(0x0408)
> #define EXYNOS5_MASK_WDTRESET_REQUEST S5P_PMUREG(0x040C)
>
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG
2012-10-09 8:34 ` Jingoo Han
@ 2012-10-31 5:47 ` Vivek Gautam
2012-11-08 4:52 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Vivek Gautam @ 2012-10-31 5:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
On Tue, Oct 9, 2012 at 2:04 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote
>>
>> EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
>> system register (base addr + 0x230). It's wrongly placed in regs-pmu.
>> Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>
> As you mentioned, this definition is wrong.
> So, it should be removed.
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>
>
>> ---
>> arch/arm/mach-exynos/include/mach/regs-pmu.h | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> index d4e392b..70b2795 100644
>> --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h
>> @@ -230,8 +230,6 @@
>>
>> /* For EXYNOS5 */
>>
>> -#define EXYNOS5_USB_CFG S5P_PMUREG(0x0230)
>> -
Any thoughts about this please.
>> #define EXYNOS5_AUTO_WDTRESET_DISABLE S5P_PMUREG(0x0408)
>> #define EXYNOS5_MASK_WDTRESET_REQUEST S5P_PMUREG(0x040C)
>>
>> --
>> 1.7.6.5
>>
--
Thanks & Regards
Vivek
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG
2012-10-09 8:34 ` Jingoo Han
2012-10-31 5:47 ` Vivek Gautam
@ 2012-11-08 4:52 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2012-11-08 4:52 UTC (permalink / raw)
To: linux-arm-kernel
Jingoo Han wrote:
>
> On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote
> >
> > EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG
> > system register (base addr + 0x230). It's wrongly placed in regs-pmu.
> > Actual register at offset 0x230 in PMU is SEQ_TRANSITION4.
> >
> > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
>
> As you mentioned, this definition is wrong.
> So, it should be removed.
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>
Applied, thanks.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-08 4:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-05 13:26 [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG Vivek Gautam
2012-10-09 8:34 ` Jingoo Han
2012-10-31 5:47 ` Vivek Gautam
2012-11-08 4:52 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).