linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: perf: fix event validation
Date: Thu, 2 Sep 2010 09:33:50 +0100	[thread overview]
Message-ID: <003e01cb4a79$921f63a0$b65e2ae0$@deacon@arm.com> (raw)
In-Reply-To: <20100901125732.GA28196@pulham.picochip.com>

Hi Jamie,

> On Wed, Sep 01, 2010 at 01:11:22PM +0100, Will Deacon wrote:
> > The validate_event function in the ARM perf events backend has the
> > following problems:
> >
> > 1.) Events that are disabled count towards the cost.
> > 2.) Events associated with other PMUs [for example, software events or
> >     breakpoints] do not count towards the cost, but do fail validation,
> >     causing the group to fail.
> >
> > This patch changes validate_event so that it ignores events in the
> > PERF_EVENT_STATE_OFF state or that are scheduled for other PMUs.
> >
> > Cc: Jamie Iles <jamie.iles@picochip.com>
> > Reported-by: Pawel Moll <pawel.moll@arm.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >
> > Resend with correct spelling of Pawel's email address on CC.
> > Jamie - are you ok with this fix?
> Yes, looks good to me.
> 
> Acked-by: Jamie Iles <jamie.iles@picochip.com>

Thanks for this. Submitted as 6352/1.

Will

  reply	other threads:[~2010-09-02  8:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 12:11 [PATCH] ARM: perf: fix event validation Will Deacon
2010-09-01 12:57 ` Jamie Iles
2010-09-02  8:33   ` Will Deacon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-08-27 15:22 Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003e01cb4a79$921f63a0$b65e2ae0$@deacon@arm.com' \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).