linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jason77.wang@gmail.com (jason wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mxc: Add support for the imx51 3-stack board
Date: Wed, 2 Jun 2010 22:36:25 +0800	[thread overview]
Message-ID: <004001cb0261$04a16380$9b00a8c0@wuef10f27ebed8> (raw)
In-Reply-To: 20100602083807.GM2346@matterhorn.lan

> On 10 Jun 01, Jason Wang wrote:
>> 3-stack is a reference board from Freescale for their i.MX51 SoC.
>> 
>> Add board definition, Kconfig and Makefile to enable Freescale 3-stack
>> board.
>> 
>> Boot tested on a i.MX51 3-stack Rev2.0 board
>> 
>> Signed-off-by: Jason Wang <jason77.wang@gmail.com>
>> ---
>>  arch/arm/mach-mx5/Kconfig                       |    5 +
>>  arch/arm/mach-mx5/Makefile                      |    2 +-
>>  arch/arm/mach-mx5/board-mx51_3ds.c              |  356 +++++++++++++++++++++++
>>  arch/arm/plat-mxc/include/mach/board-mx51_3ds.h |   73 +++++
>>  arch/arm/plat-mxc/include/mach/iomux-mx51-3ds.h |   43 +++
>>  5 files changed, 478 insertions(+), 1 deletions(-)
>>  create mode 100644 arch/arm/mach-mx5/board-mx51_3ds.c
>>  create mode 100644 arch/arm/plat-mxc/include/mach/board-mx51_3ds.h
>>  create mode 100644 arch/arm/plat-mxc/include/mach/iomux-mx51-3ds.h
<snip>
>> + .resource = mx51_3ds_kpp_resources,
>> + .dev = {
>> + .platform_data = &mx51_3ds_map_data,
>> + },
>> +};
> 
> Please move this platform device and the smsc below to devices.c, add the
> required devices for the board to an array in the board file and register it
> in board_init using
> 
> platform_add_devices(devices, ARRAY_SIZE(devices));
> 
> See the babbage board code.
> 
OK, will be fixed in V2.

Thanks,
Jason.
>> +static void mxc_init_keypad(void)
>> +{
>> + (void)platform_device_register(&mx51_3ds_keypad_device);
>> +}

<snip>
 
> Could you document expio a little better (how debug board works, at the top of
> this section)? Also, please move expio to another patch as well, I don't
> think a debug board is required for board bringup.
> 
If moving CPLD related code to a common file in near future, we can add explanation infos in Kconfig
or in that common file.

>> +/*
>> + * Disable an expio pin's interrupt by setting the bit in the imr.

<snip>

>> +#endif /* __ASM_ARCH_MXC_BOARD_MX51_3DS_H__ */
>> diff --git a/arch/arm/plat-mxc/include/mach/iomux-mx51-3ds.h b/arch/arm/plat-mxc/include/mach/iomux-mx51-3ds.h
>> new file mode 100644
>> index 0000000..33f1141
> 
> Get rid of this file and add what you need to the common iomux-mx51.h
> 
OK, will be addressed in V2.

Thanks,
Jason.
<snip>

      parent reply	other threads:[~2010-06-02 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01 15:10 [PATCH 0/3]Add i.MX51 3-stack board support Jason Wang
2010-06-01 15:10 ` [PATCH 1/3] mxc: Add support for the imx51 3-stack board Jason Wang
2010-06-01 15:10   ` [PATCH 2/3] mxc/iomux: add GPIO bank offset for iomux v3 platforms Jason Wang
2010-06-01 15:10     ` [PATCH 3/3] mx51/clock: add keypad clock definition and registration Jason Wang
2010-06-01 15:56       ` Fabio Estevam
2010-06-02 13:55         ` jason wang
2010-06-02  7:43       ` Sascha Hauer
2010-06-02 14:28         ` [PATCH 3/3] mx51/clock: add keypad clock definition andregistration jason wang
2010-06-02  8:00       ` [PATCH 3/3] mx51/clock: add keypad clock definition and registration Amit Kucheria
2010-06-02 14:29         ` jason wang
2010-06-01 15:35   ` [PATCH 1/3] mxc: Add support for the imx51 3-stack board Fabio Estevam
2010-06-02 13:53     ` jason wang
2010-06-02  7:36   ` Sascha Hauer
2010-06-02 13:08     ` Rob Herring
2010-06-02 14:27     ` jason wang
2010-06-02 17:23       ` Sascha Hauer
2010-06-03  0:01         ` jason
2010-06-02  8:38   ` Amit Kucheria
2010-06-02  8:52     ` Sascha Hauer
2010-06-02 14:36     ` jason wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004001cb0261$04a16380$9b00a8c0@wuef10f27ebed8' \
    --to=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).