From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Inki Dae'" <inki.dae@samsung.com>,
"'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
"'David Airlie'" <airlied@gmail.com>,
"'Daniel Vetter'" <daniel@ffwll.ch>,
"'Marek Szyprowski'" <m.szyprowski@samsung.com>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] drm/exynos: g2d: staticize stubs in header
Date: Sun, 7 May 2023 22:05:45 +0530 [thread overview]
Message-ID: <004001d98101$fa5ed690$ef1c83b0$@samsung.com> (raw)
In-Reply-To: <20230507144753.192959-1-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Sunday, May 7, 2023 8:18 PM
> To: Inki Dae <inki.dae@samsung.com>; Seung-Woo Kim
> <sw0312.kim@samsung.com>; Kyungmin Park
> <kyungmin.park@samsung.com>; David Airlie <airlied@gmail.com>; Daniel
> Vetter <daniel@ffwll.ch>; Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org>; Alim Akhtar <alim.akhtar@samsung.com>;
> Marek Szyprowski <m.szyprowski@samsung.com>; dri-
> devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux-
> samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/exynos: g2d: staticize stubs in header
>
> Stubs for !CONFIG_DRM_EXYNOS_G2D case in the header should be static
> inline:
>
> drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: warning: no previous
> prototype for ‘g2d_open’ [-Wmissing-prototypes]
> drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:6: warning: no previous
> prototype for ‘g2d_close’ [-Wmissing-prototypes]
>
> Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> index 74ea3c26dead..1a5ae781b56c 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h
> @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct
> drm_device *dev, void *data,
> return -ENODEV;
> }
>
> -int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file)
> {
> return 0;
> }
>
> -void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file)
> { }
> #endif
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-05-07 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230507144800epcas5p219717e5bf06b91772ee877c8dcee0940@epcas5p2.samsung.com>
2023-05-07 14:47 ` [PATCH] drm/exynos: g2d: staticize stubs in header Krzysztof Kozlowski
2023-05-07 16:35 ` Alim Akhtar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d98101$fa5ed690$ef1c83b0$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).