From: tgih.jun@samsung.com (Seungwon Jeon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mmc: dwmmc: let device core setup the default pin configuration
Date: Thu, 04 Apr 2013 14:47:02 +0900 [thread overview]
Message-ID: <004201ce30f7$d4beea20$7e3cbe60$%jun@samsung.com> (raw)
In-Reply-To: <CAD=FV=Xck5XW3LPmvkMfP=dfmnDH+kG4VYkRetW+SJ-bAz7SqQ@mail.gmail.com>
On Wednesday, April 03, 2013, Doug Anderson wrote:
> Thomas,
>
> On Mon, Apr 1, 2013 at 11:09 PM, Thomas Abraham
> <thomas.abraham@linaro.org> wrote:
> > With device core now able to setup the default pin configuration,
> > the pin configuration code based on the deprecated Samsung specific
> > gpio bindings is removed.
> >
> > Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Reviewed-by: Doug Anderson <dianders@chromium.org>
> > Tested-by: Doug Anderson <dianders@chromium.org>
>
> You missed Seungwon's other feedback. Please change the title from
> "mmc: dwmmc: let device core setup the default pin configuration" to
> "mmc: dw_mmc: let device core setup the default pin configuration".
> He requested that the tag have the underscore in it for consistency.
>
> If you're resending, it also seems like it might be nice to rebase this atop:
>
> 0f6e73d mmc: dw_mmc: Add MSHC compatible for Exynos4412
>
> ...just to avoid the simple merge conflict when applying?
>
> Otherwise everything here looks great...
>
> -Doug
Thomas,
It's a conflict to merge. Please do rebase the patch.
Thanks,
Seungwon Jeon
next prev parent reply other threads:[~2013-04-04 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 6:09 [PATCH v2] mmc: dwmmc: let device core setup the default pin configuration Thomas Abraham
2013-04-02 15:37 ` Doug Anderson
2013-04-04 5:47 ` Seungwon Jeon [this message]
2013-05-27 3:49 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004201ce30f7$d4beea20$7e3cbe60$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).