From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM perf events spin locks
Date: Tue, 30 Nov 2010 13:49:32 -0000 [thread overview]
Message-ID: <004401cb9095$6b1fbcc0$415f3640$@deacon@arm.com> (raw)
In-Reply-To: <20101130105856.GC4398@pulham.picochip.com>
Jamie,
> On Tue, Nov 30, 2010 at 10:41:04AM -0000, Will Deacon wrote:
> > > Hi Will,
> >
> > Hello,
> >
> > > I think we should convert the spinlocks in the ARM perf events code to raw
> > > spinlocks for realtime. Should we wait for your split set to get merged first
> > > before doing this?
> >
> > Since this is a logically separate change, I think we're better off waiting
> > until the split stuff has been merged. As for the raw spinlocks, by realtime
> > do you mean PREEMPT_RT? Also, do we actually *need* raw spinlocks in the perf
> > code?
> Yes, I meant PREEMPT_RT. It won't stop working without raw spinlocks but I'm
> not convinced that we couldn't lose too much accuracy with normal spinlocks. I
> am however willing to be convinced otherwise!
Well struct perf_event_ctx has a lock field which is of type raw_spinlock_t.
I *think* this is always held by the core perf code before calling the backend,
however IRQs may still be enabled so we probably do need to change our pmu_lock.
Is that a sane analysis?
Will
next prev parent reply other threads:[~2010-11-30 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 10:08 ARM perf events spin locks Jamie Iles
2010-11-30 10:41 ` Will Deacon
2010-11-30 10:58 ` Jamie Iles
2010-11-30 13:49 ` Will Deacon [this message]
2010-11-30 13:54 ` Jamie Iles
2010-11-30 13:59 ` Will Deacon
2010-11-30 14:31 ` Russell King - ARM Linux
2010-11-30 14:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004401cb9095$6b1fbcc0$415f3640$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).