From: moon9124@samsung.com (Daein Moon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/3] ARM: S5PV310: Remove L2 cache init in machine
Date: Thu, 21 Oct 2010 16:23:02 +0900 [thread overview]
Message-ID: <004601cb70f0$ce0558f0$6a100ad0$@com> (raw)
In-Reply-To: <1287643483-16046-3-git-send-email-kgene.kim@samsung.com>
Kukjin Kim wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Basically, need L2 cache initialize function in ARCH_S5PV310. So it would
> be better to move it into ARCH_S5PV310 common part. This patch removes L2
> cache initialization code at the each board file.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Changhwan Youn <chaos.youn@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/mach-s5pv310/mach-smdkc210.c | 4 ----
> arch/arm/mach-s5pv310/mach-smdkv310.c | 4 ----
> arch/arm/mach-s5pv310/mach-universal_c210.c | 4 ----
> 3 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv310/mach-smdkc210.c b/arch/arm/mach-
> s5pv310/mach-smdkc210.c
> index 93d537b..3cde5ed 100644
> --- a/arch/arm/mach-s5pv310/mach-smdkc210.c
> +++ b/arch/arm/mach-s5pv310/mach-smdkc210.c
> @@ -129,10 +129,6 @@ static void __init smdkc210_machine_init(void)
> s3c_sdhci2_set_platdata(&smdkc210_hsmmc2_pdata);
> s3c_sdhci3_set_platdata(&smdkc210_hsmmc3_pdata);
>
> -#ifdef CONFIG_CACHE_L2X0
> - l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
> -#endif
> -
Hi,
If L2 cache init is removed, including header file
"asm/hardware/cache-l2x0.h" isn't needed.
Best regards,
Daein Moon
> platform_add_devices(smdkc210_devices,
> ARRAY_SIZE(smdkc210_devices));
> }
>
> diff --git a/arch/arm/mach-s5pv310/mach-smdkv310.c b/arch/arm/mach-
> s5pv310/mach-smdkv310.c
> index 10f8056..d9a17b8 100644
> --- a/arch/arm/mach-s5pv310/mach-smdkv310.c
> +++ b/arch/arm/mach-s5pv310/mach-smdkv310.c
> @@ -129,10 +129,6 @@ static void __init smdkv310_machine_init(void)
> s3c_sdhci2_set_platdata(&smdkv310_hsmmc2_pdata);
> s3c_sdhci3_set_platdata(&smdkv310_hsmmc3_pdata);
>
> -#ifdef CONFIG_CACHE_L2X0
> - l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
> -#endif
> -
> platform_add_devices(smdkv310_devices,
> ARRAY_SIZE(smdkv310_devices));
> }
>
> diff --git a/arch/arm/mach-s5pv310/mach-universal_c210.c b/arch/arm/mach-
> s5pv310/mach-universal_c210.c
> index deffeb1..f78890f 100644
> --- a/arch/arm/mach-s5pv310/mach-universal_c210.c
> +++ b/arch/arm/mach-s5pv310/mach-universal_c210.c
> @@ -141,10 +141,6 @@ static void __init universal_map_io(void)
>
> static void __init universal_machine_init(void)
> {
> -#ifdef CONFIG_CACHE_L2X0
> - l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
> -#endif
> -
> i2c_register_board_info(0, i2c0_devs, ARRAY_SIZE(i2c0_devs));
> i2c_register_board_info(1, i2c1_devs, ARRAY_SIZE(i2c1_devs));
>
> --
> 1.6.2.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2010-10-21 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 6:44 [PATCH V3 0/3] ARM: S5PV310: Move and Update L2 cache init code Kukjin Kim
2010-10-21 6:44 ` [PATCH V3 1/3] ARM: Add L2X0 PREFETCH and POWER control register Kukjin Kim
2010-10-21 8:44 ` Catalin Marinas
2010-10-21 8:55 ` Kukjin Kim
2010-10-21 6:44 ` [PATCH V3 2/3] ARM: S5PV310: Remove L2 cache init in machine Kukjin Kim
2010-10-21 7:23 ` Daein Moon [this message]
2010-10-21 7:28 ` Kukjin Kim
2010-10-21 6:44 ` [PATCH V3 3/3] ARM: S5PV310: Add L2 cache init function in cpu.c Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004601cb70f0$ce0558f0$6a100ad0$@com' \
--to=moon9124@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox