linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API
Date: Fri, 22 Oct 2010 17:05:32 +0900	[thread overview]
Message-ID: <004901cb71bf$e8be50f0$ba3af2d0$%kim@samsung.com> (raw)
In-Reply-To: <4CC07CC2.50206@mvista.com>

Sergei Shtylyov wrote:
> 
> Hello.
> 
Hi,

> On 21-10-2010 12:04, Kukjin Kim wrote:
> 
> > From: Daein Moon<moon9124@samsung.com>
> 
> > This patch adds the s3c_gpio_getpull() API that has been missed in the
> > plat-samsung/gpio-config.c and actullay there is its extern declaration
> > in plat/gpio-cfg.h.
> 
> > Signed-off-by: Daein Moon<moon9124@samsung.com>
> > Cc: Ben Dooks<ben-linux@fluff.org>
> > Signed-off-by: Kukjin Kim<kgene.kim@samsung.com>
> > ---
> > NOTE:
> > - already issued about this
> 
> >   arch/arm/plat-samsung/gpio-config.c                |   19
> +++++++++++++++++++
> >   .../plat-samsung/include/plat/gpio-cfg-helpers.h   |    6 ++++++
> >   2 files changed, 25 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-
> samsung/gpio-config.c
> > index 8a37211..b732b77 100644
> > --- a/arch/arm/plat-samsung/gpio-config.c
> > +++ b/arch/arm/plat-samsung/gpio-config.c
> [...]
> > diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> > index 3e21c75..c417f85 100644
> > --- a/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> > +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg-helpers.h
> > @@ -42,6 +42,12 @@ static inline int s3c_gpio_do_setpull(struct
> s3c_gpio_chip *chip,
> >   	return (chip->config->set_pull)(chip, off, pull);
> >   }
> >
> > +static inline unsigned s3c_gpio_do_getpull(struct s3c_gpio_chip *chip,
> > +					   unsigned int off)
> > +{
> > +	return (chip->config->get_pull)(chip, off);
> 
>     Parens are not necessary here.
> 
Thanks for your pointing out :-)
Will fix it.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-10-22  8:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21  8:04 [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API Kukjin Kim
2010-10-21 17:47 ` Sergei Shtylyov
2010-10-22  8:05   ` Kukjin Kim [this message]
2010-10-21 22:17 ` Ben Dooks
2010-10-22  5:22   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004901cb71bf$e8be50f0$ba3af2d0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).