From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13BCFCDB474 for ; Tue, 17 Oct 2023 09:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X4lJNvoU5pnPJimQ7+qOkUg4iuUKFPgHUkyfndMWxPg=; b=QMfTJ+dlao3bCl v9Na7Ahorsh8FK+YDRTBDTwGg0rLIv9yE127bAE24HrbPmCG8owaTHxFfX+9JC1058GTFivCUK0/1 f/ahL7SqvMkZiJLbMLb+wy/OVZMinzIvtPaunbVnh954jPdnmYfxb6YXriwwv65ghx1nq2NehIS1q +rVrUgjnUrDMBDP/XNaWAp46fPd4CfNcKGSqzXq1ICdleaDvZBVbUZnwpqbvcbkIAflWhwp5xv8R8 J8Xy5dtiTA6hGofB9kjh7++tvXWUYKAoorhOElWA2broxiJZLFgB6bBiNbIGuBn60oI8fyHlP1lrd Bkk9sm1J7JH4qOaMTUFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsg8n-00BmsC-0L; Tue, 17 Oct 2023 09:13:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsg8h-00BmrC-2n for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 09:13:27 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qsg8J-0003xl-I0; Tue, 17 Oct 2023 11:12:59 +0200 Message-ID: <004d6ce9-7d15-4944-b31c-c9e628e7483a@pengutronix.de> Date: Tue, 17 Oct 2023 11:12:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Content-Language: en-US, de-DE To: Simon Horman Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Richard Cochran , Kurt Kanzenbach , patchwork-jzi@pengutronix.de, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20231010-stmmac_fix_auxiliary_event_capture-v1-0-3eeca9e844fa@pengutronix.de> <20231010-stmmac_fix_auxiliary_event_capture-v1-2-3eeca9e844fa@pengutronix.de> <20231014144428.GA1386676@kernel.org> From: Johannes Zink In-Reply-To: <20231014144428.GA1386676@kernel.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: j.zink@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_021323_926796_FF0D8372 X-CRM114-Status: GOOD ( 28.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Simon, On 10/14/23 16:44, Simon Horman wrote: > On Thu, Oct 12, 2023 at 11:02:13AM +0200, Johannes Zink wrote: >> The stmmac supports up to 4 auxiliary snapshots that can be enabled by >> setting the appropriate bits in the PTP_ACR bitfield. >> >> Previously instead of setting the bits, a fixed value was written to >> this bitfield instead of passing the appropriate bitmask. >> >> Now the correct bit is set according to the ptp_clock_request.extts_index >> passed as a parameter to stmmac_enable(). >> >> Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping") >> Signed-off-by: Johannes Zink > > Hi Johannes, > > The fix language of the subject and presence of a fixes tag implies that > this is a bug fix. But it's not clear to me that this is resolving > bug that manifests as a problem. Thank you for taking your time to read through the series. This series is somewhere in the realm between "fixing some stuff added previously (and never worked)" and "filling the gaps/adding a new feature in some template code that never worked as intended". However, I do not have strong opinions about this. If you prefer to have the commits reworded, I will just wait a bit more for any additional feedback and resend the series with the commit messages reworded+ fixes, should any be required. > > If it is a bug fix then it should probably be targeted at 'net', > creating a dependency for the remainder of this series. > > On the other hand, if it is not a bug fix then perhaps it is best to > update the subject and drop the Fixes tag. I added the fixes-Tag in order to make code archeology easier, but as it may trigger picks to stable branches (which is not required imho), I have no objections to dropping it for a v2. > > I'm no expert on stmmac, but the rest of the series looks good to me. > > ... > that's good news. thx for looking through the series. Best regards Johannes -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel