From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options
Date: Wed, 02 Nov 2011 21:12:49 +0900 [thread overview]
Message-ID: <005301cc9958$bcf5aa10$36e0fe30$%kim@samsung.com> (raw)
In-Reply-To: <1320039876-21148-1-git-send-email-rajeshwari.s@samsung.com>
Rajeshwari Shinde wrote:
>
> This patch modifies the driver to stop depending on the clock names
> being passed from the platform and switch over to bus clock lookup
> using generic clock names.
>
> V6 Changes:
> Changed sprintf to snprintf as suggested by Chris Ball.
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Hi Chirs,
Could you please pick this up in your tree for this merge window?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 82709b6..488223c 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct
> platform_device *pdev)
>
> for (clks = 0, ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
> struct clk *clk;
> - char *name = pdata->clocks[ptr];
> -
> - if (name == NULL)
> - continue;
> + char name[14];
>
> + snprintf(name, 14, "mmc_busclk.%d", ptr);
> clk = clk_get(dev, name);
> if (IS_ERR(clk)) {
> - dev_err(dev, "failed to get clock %s\n", name);
> continue;
> }
>
> --
> 1.7.4.4
next prev parent reply other threads:[~2011-11-02 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 5:44 [PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options Rajeshwari Shinde
2011-11-02 12:12 ` Kukjin Kim [this message]
2011-11-02 17:56 ` Chris Ball
2011-11-03 2:14 ` Kukjin Kim
2011-11-02 20:41 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005301cc9958$bcf5aa10$36e0fe30$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).