From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A94C43331 for ; Fri, 3 Apr 2020 11:13:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 802DD2082F for ; Fri, 3 Apr 2020 11:13:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WT/4FYnl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Lqv+7NO1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 802DD2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iyWwmYn5ILUBWfMaL5dnT93azjxD2xCJzDTuWHISJsQ=; b=WT/4FYnlRGhJ+u 0Mb/ZGWP/SfCRo4GQ5HR8ThYfdgKH1+ljBIBCju7/VUrgVw7zjYYuuTW6ZbmQ+nvrxpHaOZVRD9Ar 3nLH+aYCEknHgHh+w77bE/mTKpUrY0aKyNijxTbWcgXB1lf/Vwmwdgq6XGQcdd+2EPMl01X+JTccU FDx6XfJLRs4Ii59/91AMcblxuh3zH4HQwK3exnwAsHefTFVaUDuQmN5TZlzZelbLMQa5iaXOTMONs AZNPOeaXowYDKkoYTw4e5Pe3f3vIvMV7r09ssox4doA/ykAvpUYxDOqQQCtfj5Q1iDqSGGiYjIZeh jtdTJX25c8M3gAYvPqmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKKG1-0004Jy-QT; Fri, 03 Apr 2020 11:13:05 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKKFx-0004J9-ND for linux-arm-kernel@lists.infradead.org; Fri, 03 Apr 2020 11:13:03 +0000 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200403111258epoutp02327413e58026911baf919e8532c2b919~CSufRjyx61872718727epoutp024 for ; Fri, 3 Apr 2020 11:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200403111258epoutp02327413e58026911baf919e8532c2b919~CSufRjyx61872718727epoutp024 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1585912378; bh=pA8bbH0J0a+qUde69DwBe1rYmqYSp0wwFAR3wM309Vc=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=Lqv+7NO1rmVAXbBDIVO6yWr3G2WK3h88TYu/fPc54uRluXChWOHyq+kjr6vNtIjM8 VvHeRz8+2s5LmEiWnWqLkjedZGqCmVDYqFPwmaZldyJ0D8G0BaPYarwZ5wxdKIa9+p iSVaMV7Jia/DzQ1Ly725z+yq52xEFkV1DoUhU9aU= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p3.samsung.com (KnoxPortal) with ESMTP id 20200403111258epcas2p3ee44d19a4741efdbb83511769ec5e3fd~CSufFlx-z0608006080epcas2p3O; Fri, 3 Apr 2020 11:12:58 +0000 (GMT) Received: from epsmges2p1.samsung.com (unknown [182.195.40.189]) by epsnrtp4.localdomain (Postfix) with ESMTP id 48ty2w5FsvzMqYkY; Fri, 3 Apr 2020 11:12:56 +0000 (GMT) Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id 3B.76.04598.83A178E5; Fri, 3 Apr 2020 20:12:56 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20200403111255epcas2p3f65f59b797653cca215f587b68008dea~CSudEwg8V3171331713epcas2p3u; Fri, 3 Apr 2020 11:12:55 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200403111255epsmtrp19483369847eb24dea5b9edce8874d493~CSudD-Q7j1160411604epsmtrp15; Fri, 3 Apr 2020 11:12:55 +0000 (GMT) X-AuditID: b6c32a45-ea1ff700000011f6-5c-5e871a382f16 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 81.0E.04024.73A178E5; Fri, 3 Apr 2020 20:12:55 +0900 (KST) Received: from KORCO004660 (unknown [12.36.165.196]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200403111255epsmtip254b15dded8b30bf3eef4d68f3ccb199a~CSuc2tkOy1567915679epsmtip2O; Fri, 3 Apr 2020 11:12:55 +0000 (GMT) From: "Hyunki Koo" To: "'Krzysztof Kozlowski'" In-Reply-To: <20200403104744.GA29385@kozik-lap> Subject: RE: [PATCH v3] tty: samsung_tty: 32-bit access for TX/RX hold registers Date: Fri, 3 Apr 2020 20:12:55 +0900 Message-ID: <005601d609a8$d3243710$796ca530$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKEs4Y1dkf1SYeuuA/6Ie9wROds5QGozxKaAhmfaBwBVB8GPabhL5wA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHeXa3ezdrdV2WpxU1rlEqmZs2u4ZG0dsgEatvVupFL5t099Lu FlofNKr5gpJRkS3tzV5tOdPQoWWhpgkyP0SWpiGokb2KgZgYdbdr5Lffc875P/9znufIMdUD XC3PtThYu4XhKDxE2tQRRcfQ6qIMbf3NSPp0jRenL9ZPSuhzo18wuq+vnqAbRvtl9OuWKpyu 7GuT0L015cR2uaGhtgQ3PK/2EIbG2wUG75M3UsPPhjVpsnQuycQyOaxdw1qyrTm5FmMyte9g 5s5MfYJWF6NLpLdQGgtjZpOpXSlpMXtyOaEVSnOc4ZxCKI3heSp2W5Ld6nSwGpOVdyRTrC2H s+l0tk08Y+adFuOmbKt5q06rjdMLlVmc6U+hX2brUeVd8lVghej9klKkkAO5GQbOfJQGWEX6 EFycoEtRiMBTCCqnu3DxMI1goPg3+qdonXklERXPEHwePiIWTSAYHCkPJnAyBl7XjAU5TODG d/eIQBFGziBom/bLAgkFGQu3qruCty4jD4CragQPsJRcBz1fvwfjSjIR5vxf5zkUeq6MBXvF yLXQ/K0KEzvSwK/xuzLRbA90eoYIsSYMrpa4sIAxkD9wqO0alIqCXXD5WsX8OMvgc/cTQmQ1 TJxzzXMBtLnOE6K4DMGvyXGZmIgH98ciQSwXHKLA2xIbQCAjoHNwvrclUNzxmxDDSih2qUTh eqib/iQReTV4xluICkS5F0zmXjCZe8EE7v9eN5C0Fq1gbbzZyPJxNt3Cz25AwTWN3u1Dlf6U dkTKEbVYqQ0vylDJmON8vrkdgRyjwpQ7Ks9mqJQ5TP4J1m7NtDs5lm9HeuHhz2Pq5dlWYekt jkydPi4hQZuop/UJcTQVrmxcNHBYRRoZB3uUZW2s/Z9OIleoC1HebPXS56vmmrNoz4bUNHzr Sdf9/pU+783Z08ljq5i9sejTxpep4Z5e7MOt9KfGArrvaKS/Nvf6qcejk5eGyy4o8u4sejUX 39RqkimOjVTtH9Y4+yMyNDXRvdG+0cEXnG/b9zpNQUdR8/DQWy7r0Uh+81SoF40XTzyc/XAo vrvkMSXlTYwuGrPzzF9FKthdvAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSvK65VHucwc8fBhbNi9ezWUzZ8IHJ ov/xa2aL8+c3sFtsenyN1eLyrjlsFjPO72OyOLO4l92Bw2PTqk42j/1z17B7bF5S77F+y1UW j8+b5AJYo7hsUlJzMstSi/TtErgy/jecYy04KVQxdccE5gbG23xdjJwcEgImErt/nGDqYuTi EBLYzShx+sYbRoiEjMSEF0uYIWxhifstR1hBbCGB54wSZzeZg9hsAroSlxc/YQKxRYDszTeW s4MMYhb4xyjR/PYOM0TDE0aJU9drQGxOAX2JRXOPgS0QFgiQOHagEayGRUBF4uSbd2BxXgFL iT/n3kDZghInZz5hAbGZBbQlnt58CmXLS2x/OwfqOAWJn0+XsUIc4SZxZM0ddogaEYnZnW3M ExiFZyEZNQvJqFlIRs1C0rKAkWUVo2RqQXFuem6xYYFhXmq5XnFibnFpXrpecn7uJkZwXGlp 7mC8vCT+EKMAB6MSD+8NkfY4IdbEsuLK3EOMEhzMSiK8jjNa44R4UxIrq1KL8uOLSnNSiw8x SnOwKInzPs07FikkkJ5YkpqdmlqQWgSTZeLglGpgbDsb4e1eeUbrxPssyfAYlZw0H49znG8u 6x6qOTBd6PevZ6cnvFjkWH5O+c2uTKa9CirJMR1fv7y5efj6nRrtguA10456++9dbvdhz7Pl JaLKEj71hYpMv93YWBJr5s48942VTfoLU8XBC9uUBF19GfzljnLfURH5HLPrwIGqafHsuSsS A6fPU2Ipzkg01GIuKk4EAMvMarmnAgAA X-CMS-MailID: 20200403111255epcas2p3f65f59b797653cca215f587b68008dea X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200403102049epcas2p1d1fe95160b7f37609a8b1710c196cdd8 References: <20200401082721.19431-1-hyunki00.koo@samsung.com> <20200403102041.22015-1-hyunki00.koo@samsung.com> <20200403104744.GA29385@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200403_041302_186187_02F10A6F X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, 'Kukjin Kim' , linux-serial@vger.kernel.org, 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 02, 2020 at 7:48:38PM +0900, Krzysztof Kozlowski > On Fri, Apr 03, 2020 at 07:20:41PM +0900, Hyunki Koo wrote: > > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > > > This is required for some newer SoCs. > > > > Signed-off-by: Hyunki Koo > > --- > > v3: change rd_regl to rd_reg in line 954 for backward compatibility. > > I cannot find this change against v2. Okay, I will add all changes. > > > --- > > > > drivers/tty/serial/samsung_tty.c | 76 > > +++++++++++++++++++++++++++++++++------- > > 1 file changed, 64 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/tty/serial/samsung_tty.c > > b/drivers/tty/serial/samsung_tty.c > > index 73f951d65b93..a674a80163ed 100644 > > --- a/drivers/tty/serial/samsung_tty.c > > +++ b/drivers/tty/serial/samsung_tty.c > > @@ -154,12 +154,47 @@ struct s3c24xx_uart_port { #define > > portaddrl(port, reg) \ > > ((unsigned long *)(unsigned long)((port)->membase + (reg))) > > > > -#define rd_regb(port, reg) (readb_relaxed(portaddr(port, reg))) > > +static unsigned int rd_reg(struct uart_port *port, int reg) > > You should return here u32 to be consistent with readl_relaxed. > > > +{ > > + switch (port->iotype) { > > + case UPIO_MEM: > > + return readb_relaxed(portaddr(port, reg)); > > + case UPIO_MEM32: > > + return readl_relaxed(portaddr(port, reg)); > > + default: > > + return 0; > > + } > > + return 0; > > +} > > + > > #define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg))) > > > > -#define wr_regb(port, reg, val) writeb_relaxed(val, portaddr(port, > > reg)) > > +static void wr_reg(struct uart_port *port, int reg, int val) > > val should be u32. Okay, I will apply it. > > > +{ > > + switch (port->iotype) { > > + case UPIO_MEM: > > + writeb_relaxed(val, portaddr(port, reg)); > > + break; > > + case UPIO_MEM32: > > + writel_relaxed(val, portaddr(port, reg)); > > + break; > > + } > > +} > > + > > #define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, > > reg)) > > > > +static void write_buf(struct uart_port *port, int reg, int val) > > buf is misleading, you do not write here any buffer. Maybe > "wr_reg_barrier()" or "wr_reg_order()"? Okay, wr_reg_barrier would be good, I will apply it. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel