From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: perf: avoid exposing internal stop function for v6 PMU
Date: Tue, 16 Nov 2010 09:57:05 -0000 [thread overview]
Message-ID: <006001cb8574$a03883f0$e0a98bd0$@deacon@arm.com> (raw)
In-Reply-To: <20101115190228.GB2764@pulham.picochip.com>
Hi Jamie,
> On Mon, Nov 15, 2010 at 05:31:00PM +0000, Will Deacon wrote:
> > Unlike other pmu functions, armv6pmu_pmu_stop is not declared static.
> > This patch adds the missing keyword.
> >
> > Cc: Jamie Iles <jamie.iles@picochip.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> Yep, good spot. Btw, my employer has changed to Exchange for our email and it
> has a habit of munging patches on the way in so I'll have to switch to my
> personal email now!
Urgh! We have to use Exchange too and it makes a total mess of patches.
You can run dos2unix and write a script to fix wrapped lines but you get
into trouble when there is trailing whitespace in a file and diff uses
that line for context. Then I usually resort to hexdump, which takes far
too long to be practical for larger patches.
> Acked-by: Jamie Iles <jamie@jamieiles.com>
Thanks. I'll use this email address in future.
Will
next prev parent reply other threads:[~2010-11-16 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:30 [PATCH 0/5] ARM: perf: split up perf_event.c by architecture Will Deacon
2010-11-15 17:30 ` [PATCH 1/5] ARM: perf: consolidate common PMU behaviour Will Deacon
2010-11-16 8:59 ` Jean Pihet
2010-11-16 9:47 ` Will Deacon
2010-11-16 9:16 ` Jamie Iles
2010-11-15 17:31 ` [PATCH 2/5] ARM: perf: avoid exposing internal stop function for v6 PMU Will Deacon
2010-11-15 19:02 ` Jamie Iles
2010-11-16 9:57 ` Will Deacon [this message]
2010-11-15 17:31 ` [PATCH 3/5] ARM: perf: add _init() functions to PMUs Will Deacon
2010-11-16 9:00 ` Jean Pihet
2010-11-16 9:18 ` Jamie Iles
2010-11-15 17:31 ` [PATCH 4/5] ARM: perf: encode PMU name in arm_pmu structure Will Deacon
2010-11-15 19:03 ` Jamie Iles
2010-11-16 8:29 ` Jean Pihet
2010-11-15 17:31 ` [PATCH 5/5] ARM: perf: separate PMU backends into multiple files Will Deacon
2010-11-16 9:11 ` Jean Pihet
2010-11-16 10:12 ` Will Deacon
2010-11-16 8:32 ` [PATCH 0/5] ARM: perf: split up perf_event.c by architecture Jean Pihet
2010-11-16 9:38 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006001cb8574$a03883f0$e0a98bd0$@deacon@arm.com' \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).