linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jg1.han@samsung.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping
Date: Thu, 28 Nov 2013 14:54:19 +0900	[thread overview]
Message-ID: <006401ceebfe$47ab6b00$d7024100$%han@samsung.com> (raw)
In-Reply-To: <20131127083637.GD12773@pratyush-vbox>

On Wednesday, November 27, 2013 5:37 PM, Pratyush Anand wrote:
> On Wed, Nov 27, 2013 at 04:24:47PM +0800, Marek Vasut wrote:
> > > On Wed, Nov 27, 2013 at 04:46:09AM +0800, Marek Vasut wrote:
> > > > Dear Pratyush Anand,
> > > >
> > > > > Hi,
> > > > >
> > > > > On Wed, Oct 23, 2013 at 12:55:43PM +0800, Tim Harvey wrote:
> > > > > > The IMX6 iATU is used for address translation between the AXI bus
> > > > > > address space and PCI address space.  This is used for type0 and
> > > > > > type1 config cycles but is not necessary for outbound io/mem
> > > > > > regions.
> > > > > >
> > > > > > This patch removes the calls that inappropriately re-configures the
> > > > > > ATU viewport for outbound memory and IO after config cycles and
> > > > > > removes them altogether as they are not necessary.
> > > > > >
> > > > > > This resolves issues with PCI devices behind switches and has been
> > > > > > tested with a Gige device behind a PLX PEX860x switch.  More testing
> > > > > > is needed for other configurations.
> > > > >
> > > > > It seems to me that in your controller you have only one view port.
> > > > > Also mem_base and mem_bus_addr is same. Thats why it works in your
> > > > > case.
> > > >
> > > > MX6 has 4 In/4 Out viewports AFAICT.
> > >
> > > Then if I do not miss anything, MX6 should work even without this patch.
> >
> > Yes, yet, it does not. On the other hand, this defect is only problematic if you
> > use the devices behind a switch. Do you use a PCIe switch on your platform
> > please?
> 
> I had tested with device under bridge.
> Mohit is in process of validating SPEAr patches with latest kernel.
> Mohit, see if we can arrange a switch and test, once SPEAr platform is
> ready with latest kernel.

I agree with Pratyush Anand's opinion.
One of our engineers had tested PCI cards under switch.
As far as I know, there was no issue about this.
However, currently, I don't have any switches. So, I
Cannot test this on Exynos platform.

Mohit,
If you test a switch on SPEAr platform, it will be
very helpful. Thank you.

Best regards,
Jingoo Han

  parent reply	other threads:[~2013-11-28  5:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-23  4:55 [PATCH RFC] PCI: imx6: remove outbound io/mem ATU region mapping Tim Harvey
2013-10-23  5:04 ` Marek Vasut
2013-10-23  6:40 ` Pratyush Anand
2013-11-26 20:46   ` Marek Vasut
2013-11-27  3:50     ` Pratyush Anand
2013-11-27  7:42       ` Richard Zhu
2013-11-27  8:24       ` Marek Vasut
2013-11-27  8:36         ` Pratyush Anand
2013-11-27  8:45           ` Marek Vasut
2013-11-28  5:54           ` Jingoo Han [this message]
2013-11-29  2:21             ` Marek Vasut
2013-12-03  3:04               ` Richard Zhu
2013-12-03  9:19                 ` Marek Vasut
2013-12-04  2:38                   ` Richard Zhu
2013-12-04 15:45                     ` Marek Vasut
2013-12-05  0:46                       ` Richard Zhu
2013-11-25 23:09 ` Bjorn Helgaas
2013-11-26 20:47   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006401ceebfe$47ab6b00$d7024100$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).