From: jongsun.han@samsung.com (Jongsun Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt
Date: Thu, 30 Sep 2010 18:45:24 +0900 [thread overview]
Message-ID: <006a01cb6084$348e9460$9dabbd20$%han@samsung.com> (raw)
In-Reply-To: <AANLkTim2saP2wGxF1U3v-p=PRvqOD+TFJwQ772kt1N-F@mail.gmail.com>
On Thu, Sep 30, 2010 at 5:45 PM, Lothar Wa?mann <LW@karo-electronics.de>
> wrote:
> > Kyungmin Park writes:
> >> From: Kyungmin Park <kyungmin.park@samsung.com>
> >>
> >> Use the correct I2C2 interrupt.
> >>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >> ---
> >> ?arch/arm/plat-samsung/dev-i2c2.c | ? ?4 ++--
> >> ?1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-samsung/dev-i2c2.c b/arch/arm/plat-
> samsung/dev-i2c2.c
> >> index 07036de..ff4ba69 100644
> >> --- a/arch/arm/plat-samsung/dev-i2c2.c
> >> +++ b/arch/arm/plat-samsung/dev-i2c2.c
> >> @@ -32,8 +32,8 @@ static struct resource s3c_i2c_resource[] = {
> >> ? ? ? ? ? ? ? .flags = IORESOURCE_MEM,
> >> ? ? ? },
> >> ? ? ? [1] = {
> >> - ? ? ? ? ? ? .start = IRQ_CAN0,
> >> - ? ? ? ? ? ? .end ? = IRQ_CAN0,
> >> + ? ? ? ? ? ? .start = IRQ_IIC2,
> >> + ? ? ? ? ? ? .end ? = IRQ_IIC2,
> >>
> > Is there any reason for using 'IIC' here to refer to 'I2C'?
>
> Historical reason previous s3c24xx series use this name. I don't want
> to break the s3c24xx series codes.
> Instead I use the I2C after S5P series. I2C3, I2C4 and so on.
>
> If all person who works on s3c24xx and s5p series agree that use the
> I2C. It can be used.
>
> Thank you,
> Kyungmin Park
Hi, Kyungmin
IRQ_CAN0 is also used in arch/arm/mach-s5pc100/include/mach/irqs.h
Best Regards
Jongsun Han
next prev parent reply other threads:[~2010-09-30 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 4:48 [PATCH 3/7] ARM: Samsung: Use the correct I2C2 interrupt Kyungmin Park
2010-09-30 8:45 ` Lothar Waßmann
2010-09-30 9:16 ` Kyungmin Park
2010-09-30 9:45 ` Jongsun Han [this message]
2010-09-30 9:50 ` Kyungmin Park
2010-10-07 1:29 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006a01cb6084$348e9460$9dabbd20$%han@samsung.com' \
--to=jongsun.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).