public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5P: Add PMU device
Date: Mon, 05 Jul 2010 21:57:26 +0900	[thread overview]
Message-ID: <006c01cb1c41$a0af5c10$e20e1430$%kim@samsung.com> (raw)
In-Reply-To: <4C31C47C.1050905@gmail.com>

Maurus Cuelenaere wrote:
> 
>  Op 05-07-10 03:46, Joonyoung Shim schreef:
> > This patch adds an initcall for the s5p platforms so that they register
> > their PMU IRQs with the PMU framework in the Kernel.
> >
> > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> > ---
> >  arch/arm/mach-s5p6442/include/mach/irqs.h |    2 +-
> >  arch/arm/mach-s5pc100/include/mach/irqs.h |    1 +
> >  arch/arm/mach-s5pv210/include/mach/irqs.h |    1 +
> >  arch/arm/plat-s5p/Makefile                |    1 +
> >  arch/arm/plat-s5p/dev-pmu.c               |   37
> +++++++++++++++++++++++++++++
> >  5 files changed, 41 insertions(+), 1 deletions(-)
> >  create mode 100644 arch/arm/plat-s5p/dev-pmu.c
> 
> Wouldn't it be better if this was in plat-samsung? I can see that the S3C6410
> datasheet mentions a PMU_IRQ_ENABLE bit in SYS_OTHERS so I suspect that it
> has
> the same functionality (even though there's no mention of which interrupt this
> is).
> 
Yes, I also found PMU_IRQ_ENABLE bit in System Others register of S3C6410 datasheet. But as your comments, could not found the interrupt number and any description...Actually, need to check whether it's available or not.

And S5P6440 has it.
So Joonyoung, it would be helpful if you could add 6440 PMUIRQ (VIC1[23]) in this patch.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-07-05 12:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  1:46 [PATCH] ARM: S5P: Add PMU device Joonyoung Shim
2010-07-05 11:39 ` Maurus Cuelenaere
2010-07-05 12:57   ` Kukjin Kim [this message]
2010-07-06  0:50     ` Kyungmin Park
2010-07-06  3:12       ` Kukjin Kim
2010-07-06  4:09         ` Kyungmin Park
2010-07-06  1:48     ` Joonyoung Shim
2010-07-06  3:23       ` Kukjin Kim
2010-07-12  4:20       ` Kukjin Kim
2010-07-05 12:44 ` Kukjin Kim
2010-07-06  1:56   ` Joonyoung Shim
2010-07-06  3:43     ` Kukjin Kim
2010-07-06  7:09       ` Joonyoung Shim
2010-07-07  0:26         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006c01cb1c41$a0af5c10$e20e1430$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox