From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A3BEC433F5 for ; Mon, 25 Oct 2021 14:27:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C95B060EE3 for ; Mon, 25 Oct 2021 14:27:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C95B060EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=akIIXzKYBhfx6KKtItD2Bbe4QOjkmpmtasRcUxhWZQY=; b=co81NVLNzSrAYJ ioU3spiZx/rmpkeGoquiorP5MuYuB5aHgT/fGpQ5jne0m+yw744ewCQYweLZYgSDhdYhrjLXgFwwF oP2g36Zx88ErXEG7LcP2ycdZPkzMfUxILxyQ7a1VqQV4paZcXjBMN22QIM03PyCRf5quLWEc4o8NB qv9d7YrlsrAtxXUytNhV/ll7Xbg1zj8iRugwY+huDqduSlwOkvmdBtbfKS92B3T+BwcfrWsO5+j/R Kb6llbDmI2hEa/W2u71+n73lppJ5ILFF4jujRii2aCU2pNEQtXC5n4l3xy5PXcZHf9kfjAlc8wzTs 5fz8CaYKSxrGt7aA6GeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0vk-00GgJD-KC; Mon, 25 Oct 2021 14:26:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0vW-00GgFt-LR for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 14:26:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635171973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bye7ObUVwxXJ2WkSXV7ATW6vdQkdYkTKPDS9mWywO4k=; b=VG20wsfW81XXPKqAw5GP7sPzbhA4Uz7GMRjfobhJBnMpVfvvUHWtqpsDWNV2Ht62lM784j pmJYBcOfQP8oznAKfuriTSHgRiFZxel+Z5PdBLZkPiya2ceE8r5gdUcHnnS6TYFTDxslEe 4hEwvDnnw9gXIQwLAumNBYRTW6lPNLM= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-b0VGioBrNLiRO1hFHXPlCQ-1; Mon, 25 Oct 2021 10:26:12 -0400 X-MC-Unique: b0VGioBrNLiRO1hFHXPlCQ-1 Received: by mail-ed1-f69.google.com with SMTP id x13-20020a05640226cd00b003dd4720703bso4122260edd.8 for ; Mon, 25 Oct 2021 07:26:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bye7ObUVwxXJ2WkSXV7ATW6vdQkdYkTKPDS9mWywO4k=; b=00WHc5kQg+blQGUU/3dCpCsjW0WP7YndofhWxwJSeA9nvh2BlzA+pwkqt9QkvUE+zO MLVBtZBpCAe5wzqiwjZePvtGXL7Q+xIzopjtmhQ5X2dG7/FRzjiLyKFrpjAM34aAtyR0 D/IaJlIYR5pkOtln6zaaMCCLICvupaNLJGgJvcPtCqGeddalboFha5tLB912PuS6Dp3T YYOsgQu+qFWoOYFXArOl+8E1NxbeG74JNWAtbfLKgRSywaZtCYybw0zswAAfgqTopYKl 0d7DLLGP0LF4XrG4sQF8zJtsMBSsUMRR2l0JsdB31HHhctRBLnkvbnWXMFfLgBKs+jIu WgOQ== X-Gm-Message-State: AOAM530iHE9H1BPoOK5MGS5bF9c6I6nklrj99mkPx2sD+yByEwQy60kg rg5+gPHispSHMS5W9hpehP1ubhhhudv0DD4H1rkNDvUyy6XeapSyrFaoAr6R4I8u6tDLh7jALEK yy6SRQFiGBgE385kuq9IqTdtAkZz5TjCcqHU= X-Received: by 2002:a17:906:c0cf:: with SMTP id bn15mr21819142ejb.54.1635171971318; Mon, 25 Oct 2021 07:26:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1tQyM0wVdwMUOMrIgmjrbrmjI7F4R9FGcgAmNEuZGC3NNZA+IU7BqgOO63yxAXGZ3HmbepA== X-Received: by 2002:a17:906:c0cf:: with SMTP id bn15mr21819096ejb.54.1635171971137; Mon, 25 Oct 2021 07:26:11 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id g14sm5171403edp.31.2021.10.25.07.26.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 07:26:10 -0700 (PDT) Message-ID: <0072221e-02e8-4d60-9b0f-80d8c423bf4e@redhat.com> Date: Mon, 25 Oct 2021 16:26:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 16/43] KVM: Don't redo ktime_get() when calculating halt-polling stop/deadline To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-17-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-17-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_072614_807382_0D3D9DE5 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/10/21 04:12, Sean Christopherson wrote: > Calculate the halt-polling "stop" time using "cur" instead of redoing > ktime_get(). In the happy case where hardware correctly predicts > do_halt_poll, "cur" is only a few cycles old. And if the branch is > mispredicted, arguably that extra latency should count toward the > halt-polling time. > > In all likelihood, the numbers involved are in the noise and either > approach is perfectly ok. Using "start" makes the change even more obvious, so: Calculate the halt-polling "stop" time using "start" instead of redoing ktime_get(). In practice, the numbers involved are in the noise (e.g., in the happy case where hardware correctly predicts do_halt_poll and there are no interrupts, "start" is probably only a few cycles old) and either approach is perfectly ok. But it's more precise to count any extra latency toward the halt-polling time. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel