linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: S5P6440: Add RTC support for S5P6440
Date: Thu, 29 Jul 2010 10:37:18 +0900	[thread overview]
Message-ID: <007601cb2ebe$978d87d0$c6a89770$%kim@samsung.com> (raw)
In-Reply-To: <4C507367.1000206@simtec.co.uk>

Ben Dooks wrote:
> 
> On 21/07/10 10:00, Kukjin Kim wrote:
> > From: Atul Dahiya <atul.dahiya@samsung.com>
> >
> > This patch adds support RTC driver for Samsung S5P6440.
> >
> > Signed-off-by: Atul Dahiya <atul.dahiya@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> >  arch/arm/mach-s5p6440/Kconfig            |    2 ++
> >  arch/arm/mach-s5p6440/include/mach/map.h |    2 +-
> >  arch/arm/mach-s5p6440/mach-smdk6440.c    |    1 +
> >  3 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-s5p6440/Kconfig
b/arch/arm/mach-s5p6440/Kconfig
> > index f066fae..b2d4716 100644
> > --- a/arch/arm/mach-s5p6440/Kconfig
> > +++ b/arch/arm/mach-s5p6440/Kconfig
> > @@ -18,7 +18,9 @@ config MACH_SMDK6440
> >  	select CPU_S5P6440
> >  	select SAMSUNG_DEV_TS
> >  	select SAMSUNG_DEV_ADC
> > +	select S3C_DEV_RTC
> >  	select S3C_DEV_WDT
> > +	select HAVE_S3C_RTC
> >  	select HAVE_S3C2410_WATCHDOG
> >  	help
> >  	  Machine support for the Samsung SMDK6440
> 
> I'm considering we shoudl just set HAVE_S3C_RTC for
> each SOC, as allowing it to compile isn't going to
> end up causing a problem. Adding it to each machine
> will end up with large Kconfig entries for each.
> 
Yes..I agree with you...So submitted '[PATCH] ARM: SAMSUNG: Make RTC driver
dependency SoC specific instead of machine specific' together.
And to separate moving dependency from machine to SoC patch can help to
avoid conflict during merging because as you know adding it to each SoC
needs to change arch/arm/Kconfig.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-07-29  1:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-21  9:00 [PATCH 0/5] Add RTC support SMDK6410, SMDKC100, SMDKC110 and SMDKV210 Kukjin Kim
2010-07-21  9:00 ` [PATCH 1/5] ARM: S3C64XX: Add RTC support for S3C64XX Kukjin Kim
2010-07-21  9:00 ` [PATCH 2/5] rtc: rtc-s3c: Add extra option to include RTC for Samsung SoCs Kukjin Kim
2010-07-21  9:00 ` [PATCH 3/5] ARM: S5P6440: Add RTC support for S5P6440 Kukjin Kim
2010-07-28 18:13   ` Ben Dooks
2010-07-29  1:37     ` Kukjin Kim [this message]
2010-07-21  9:00 ` [PATCH 4/5] ARM: S5PC100: Add RTC support for S5PC100 Kukjin Kim
2010-07-21  9:00 ` [PATCH 5/5] ARM: S5PV210: Add RTC support for S5PV210 and S5PC110 Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007601cb2ebe$978d87d0$c6a89770$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).