From: moon9124@samsung.com (Daein Moon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: S5PV310: Add support SROMC
Date: Fri, 15 Oct 2010 15:37:39 +0900 [thread overview]
Message-ID: <007c01cb6c33$7653dad0$62fb9070$@com> (raw)
In-Reply-To: <00e301cb6ad7$3842b5c0$a8c82140$%szyprowski@samsung.com>
Marek Szyprowski wrote:
>
> Hello,
>
> On Wednesday, October 13, 2010 2:16 PM Sangbeom Kim wrote:
>
> > From: Daein Moon <moon9124@samsung.com>
> >
> > This patch adds support SROMC for S5PV310 and S5PC210.
> >
> > Signed-off-by: Daein Moon <moon9124@samsung.com>
> > Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
> > ---
> > arch/arm/mach-s5pv310/cpu.c | 5 ++
> > arch/arm/mach-s5pv310/include/mach/map.h | 4 ++
> > arch/arm/mach-s5pv310/include/mach/regs-srom.h | 50
> ++++++++++++++++++++++++
> > 3 files changed, 59 insertions(+), 0 deletions(-)
> > create mode 100644 arch/arm/mach-s5pv310/include/mach/regs-srom.h
> >
> > diff --git a/arch/arm/mach-s5pv310/cpu.c b/arch/arm/mach-s5pv310/cpu.c
> > index ffed262..873783a 100644
> > --- a/arch/arm/mach-s5pv310/cpu.c
> > +++ b/arch/arm/mach-s5pv310/cpu.c
> > @@ -81,6 +81,11 @@ static struct map_desc s5pv310_iodesc[] __initdata =
> {
> > .pfn = __phys_to_pfn(S3C_PA_UART),
> > .length = SZ_512K,
> > .type = MT_DEVICE,
> > + }, {
> > + .virtual = (unsigned long)S5P_VA_SROMC,
> > + .pfn = __phys_to_pfn(S5PV310_PA_SROMC),
> > + .length = SZ_4K,
> > + .type = MT_DEVICE,
> > },
> > };
>
> Do You really need to make a permanent mapping for the SROMC area? Cannot
the
> setup code in the mach-smdk*.c call ioremap(S5PV310_PA_SROMC) and put the
address it
> got to the ethernet device? This area will be probably useless for boards
other than
> SMDK.
>
Hi,
It seems to be useless because only ethernet device uses the SROM interface.
Will this mapping be ready for devices that will use the SROM interface in
boards
other than SMDK?
Best regards,
Daein Moon
> <snip>
>
> Best regards
> --
> Marek Szyprowski
> Samsung Poland R&D Center
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2010-10-15 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 12:15 [PATCH 0/2] ARM: S5PV310: Add support ethernet for SMDKV310 and SMDKC210 Sangbeom Kim
2010-10-13 12:15 ` [PATCH 1/2] ARM: S5PV310: Add support SROMC Sangbeom Kim
2010-10-13 13:04 ` Marek Szyprowski
2010-10-15 6:37 ` Daein Moon [this message]
2010-10-22 5:50 ` Kukjin Kim
2010-10-13 12:15 ` [PATCH 2/2] ARM: S5PV310: Support ethernet for SMDKV310 and SMDKC210 Sangbeom Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007c01cb6c33$7653dad0$62fb9070$@com' \
--to=moon9124@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).