From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] gpio/exynos: Add support for Exynos4x12 SoC
Date: Thu, 24 May 2012 17:36:29 +0900 [thread overview]
Message-ID: <008201cd3988$50731ff0$f1595fd0$%kim@samsung.com> (raw)
In-Reply-To: <4FB5B9CA.6060705@samsung.com>
Joonyoung Shim wrote:
>
> Add to cc Grant Likely and Linus Walleij
>
> On 05/18/2012 11:18 AM, Joonyoung Shim wrote:
> > Exynos4x12 GPIO part1 and part2 layouts are different with that of
> > Exynos4210. So, it needs to support gpios for Exynos4x12 SoC. This
> > doesn't support GPVx Exynos4x12 GPIO part4 yet.
> >
> > In the Exynos4x12 GPIO part1 and part2, the interval of base register
> > offset is 0x20 but GPF0, GPJ0, GPK0 and GPM0 ignore the 0x20 interval
> > and have new value. The interrupt reg offset also is about GPF0 and GPK0
> > too. Refer the below layout.
> >
> > - Exynos4x12 GPIO Part1
> > GPIO Base offset Interrupt reg offset
> > GPA0 0x000 0x00
> > GPA1 0x020 0x04
> > GPB 0x040 0x08
> > GPC0 0x060 0x0C
> > GPC1 0x080 0x10
> > GPD0 0x0A0 0x14
> > GPD1 0x0C0 0x18
> > ...
> > GPF0 0x180 0x30
> > GPF1 0x1A0 0x34
> > GPF2 0x1C0 0x38
> > GPF3 0x1E0 0x3C
> > ...
> > GPJ0 0x240 0x40
> > GPJ1 0x260 0x44
> >
> > - Exynos4x12 GPIO Part2
> > ...
> > GPK0 0x040 0x08
> > GPK1 0x060 0x0C
> > GPK2 0x080 0x10
> > GPK3 0x0A0 0x14
> > GPL0 0x0C0 0x18
> > GPL1 0x0E0 0x1C
> > GPL2 0x100 0x20
> > GPY0 0x120 x
> > GPY1 0x140 x
> > GPY2 0x160 x
> > GPY3 0x180 x
> > GPY4 0x1A0 x
> > GPY5 0x1C0 x
> > GPY6 0x1E0 x
> > ...
> > GPM0 0x260 0x24
> > GPM1 0x280 0x28
> > GPM2 0x2A0 0x2C
> > GPM3 0x2C0 0x30
> > GPM4 0x2E0 0x34
> > GPX0 0xC00 x
> > GPX1 0xC20 x
> > GPX2 0xC40 x
> > GPX3 0xC60 x
> >
> > Signed-off-by: Joonyoung Shim<jy0922.shim@samsung.com>
> > Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> > ---
> > arch/arm/mach-exynos/include/mach/gpio.h | 28 +++-
> > arch/arm/mach-exynos/include/mach/irqs.h | 6 -
> > drivers/gpio/gpio-samsung.c | 334
> +++++++++++++++++++++++++++---
> > 3 files changed, 327 insertions(+), 41 deletions(-)
See my comments on 1/2 patch.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-05-24 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 2:18 [PATCH 1/2] ARM: EXYYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx Joonyoung Shim
2012-05-18 2:18 ` [PATCH 2/2] gpio/exynos: Add support for Exynos4x12 SoC Joonyoung Shim
2012-05-18 2:54 ` Joonyoung Shim
2012-05-18 8:21 ` Sylwester Nawrocki
2012-05-24 8:36 ` Kukjin Kim [this message]
2012-05-18 2:53 ` [PATCH 1/2] ARM: EXYYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx Joonyoung Shim
2012-05-18 8:20 ` Sylwester Nawrocki
2012-05-18 8:24 ` Sylwester Nawrocki
2012-05-24 8:35 ` Kukjin Kim
2012-08-07 8:09 ` Kukjin Kim
2012-08-08 6:27 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008201cd3988$50731ff0$f1595fd0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox