linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c
Date: Wed, 19 Dec 2012 10:30:15 -0800	[thread overview]
Message-ID: <008701cdde16$e58b2280$b0a16780$@samsung.com> (raw)
In-Reply-To: CAOesGMhgvsM7Fk-YpihjYM6h+xqK-ejBzPKEDypfdKEmHp6ZJg@mail.gmail.com

Kukjin Kim wrote:
> 
> Olof Johansson wrote:
> 
> [...]
> 
> > Looks like the breakage was caused by the following commit:
> >
> > commit 1974a042dd15f1f007a3a1a2dd7a23ca0e42c01d
> > Author:     Padmavathi Venna <padma.v@samsung.com>
> > AuthorDate: Wed Nov 28 16:17:48 2012 +0530
> > Commit:     Mark Brown <broonie@opensource.wolfsonmicro.com>
> > CommitDate: Wed Nov 28 19:18:00 2012 +0000
> >
> >     ASoC: Samsung: Get I2S src_clk from clock alias id.
> >
> > Padmavathi, you can't send out code that breaks all Samsung platforms
> > like this, even if there are patches out there that fixes it. Changes
> > have to be bisectable, which means that you can't break and unbreak
> > the build, least of all if you merge through different maintainers.
> > And you need to tell the other maintainer that there are dependent
> > patches, you just sent the above patch to Mark without any such
> > information.
> >
> Oops, I thought the 'src_clk'  should be restored with my drop the commit
> 48a2050d ("ARM: SAMSUNG: Delete the unnecessary variable"), however,
> seems other patch has same changes...What's happening?
> 
> See below,
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134979.html
> 
> > Kukjin, I see that Padmavathi has posted a V3 series of patches to
> > remove all this from the dev-audio files on November 23. Are you ok
> > with us picking them up and sending ASAP?
> >
> Hmm, just Mark's following can fix it but I didn't look at it yet.
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> November/134911.html
> 
Olof, I sent 'git pull request' for fix the problems just now, please check
it.

Thanks.

- Kukjin

      parent reply	other threads:[~2012-12-19 18:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <000701cdd9d3$3b6a6e10$b23f4a30$%choi@samsung.com>
2012-12-17  0:42 ` [PATCH] ARM: EXYNOS: Fix compile error in dev-audio.c Olof Johansson
2012-12-17  4:18   ` Padma Venkat
2012-12-19  2:49   ` Kukjin Kim
2012-12-19 18:30   ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='008701cdde16$e58b2280$b0a16780$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).