* [PATCH] arm64: dts: exynos: Added the ethernet pin configuration [not found] <CGME20250423060042epcas5p2c04be779e21089f33b8a9a7785bb151a@epcas5p2.samsung.com> @ 2025-04-23 6:00 ` Yashwant Varur 2025-04-23 8:23 ` Alim Akhtar ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Yashwant Varur @ 2025-04-23 6:00 UTC (permalink / raw) To: robh, krzk+dt, conor+dt, alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed, yashwant.v This patch adds the ethernet pin configuration. Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> --- .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi index 663e8265cbf5..778584d339d5 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { interrupt-controller; #interrupt-cells = <2>; }; + + eth0_pps_out: eth0_pps_out { + samsung,pins = "gph3-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + }; + + eth0_rgmii: eth0_rgmii { + samsung,pins = "gph3-1", "gph3-2", "gph3-3", "gph3-4", + "gph3-5", "gph3-6", "gph3-7", "gph4-0", + "gph4-1", "gph4-2", "gph4-3", "gph4-4"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth0_mdc_mdio: eth0_mdc_mdio { + samsung,pins = "gph4-5", "gph4-6"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; }; &pinctrl_hsi2ufs { @@ -750,6 +768,29 @@ i3c3_bus: i3c3-bus-pins { samsung,pin-function = <EXYNOS_PIN_FUNC_4>; samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; }; + + eth_extpll_avb: eth_extpll_avb { + samsung,pins = "gpg3-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>; + }; + + eth0_pps_out0: eth0_pps_out0 { + samsung,pins = "gpg0-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth0_pps_out1: eth0_pps_out1 { + samsung,pins = "gpg0-1"; + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; + }; + + eth_phy_reset: eth_phy_reset { + samsung,pins = "gpg3-1"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + }; + }; &pinctrl_peric1 { -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-23 6:00 ` [PATCH] arm64: dts: exynos: Added the ethernet pin configuration Yashwant Varur @ 2025-04-23 8:23 ` Alim Akhtar 2025-04-23 13:37 ` Rob Herring (Arm) 2025-04-23 15:11 ` Krzysztof Kozlowski 2 siblings, 0 replies; 7+ messages in thread From: Alim Akhtar @ 2025-04-23 8:23 UTC (permalink / raw) To: 'Yashwant Varur', robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed Hi Yashwant, > -----Original Message----- > From: Yashwant Varur <yashwant.v@samsung.com> > Sent: Wednesday, April 23, 2025 11:31 AM > To: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; > niyas.ahmed@samsung.com; yashwant.v@samsung.com > Subject: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration > > This patch adds the ethernet pin configuration. > Please follow https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes to describe our changes. > Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> > Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> > --- > .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > index 663e8265cbf5..778584d339d5 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + eth0_pps_out: eth0_pps_out { > + samsung,pins = "gph3-0"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + }; > + > + eth0_rgmii: eth0_rgmii { > + samsung,pins = "gph3-1", "gph3-2", "gph3-3", "gph3-4", > + "gph3-5", "gph3-6", "gph3-7", "gph4-0", > + "gph4-1", "gph4-2", "gph4-3", "gph4-4"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > + }; > + > + eth0_mdc_mdio: eth0_mdc_mdio { > + samsung,pins = "gph4-5", "gph4-6"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_2>; No need to set drive strength and pull-{up/down}?? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-23 6:00 ` [PATCH] arm64: dts: exynos: Added the ethernet pin configuration Yashwant Varur 2025-04-23 8:23 ` Alim Akhtar @ 2025-04-23 13:37 ` Rob Herring (Arm) 2025-04-23 15:11 ` Krzysztof Kozlowski 2 siblings, 0 replies; 7+ messages in thread From: Rob Herring (Arm) @ 2025-04-23 13:37 UTC (permalink / raw) To: Yashwant Varur Cc: conor+dt, linux-arm-kernel, niyas.ahmed, linux-kernel, g.naidu, devicetree, krzk+dt, cs0617.lee, linux-samsung-soc, alim.akhtar On Wed, 23 Apr 2025 11:30:34 +0530, Yashwant Varur wrote: > This patch adds the ethernet pin configuration. > > Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> > Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> > --- > .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: attempting to guess base-commit... Base: tags/next-20250423 (exact match) If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250423060034.973-1-yashwant.v@samsung.com: arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: pinctrl@10830000 (samsung,exynosautov920-pinctrl): 'eth0_pps_out0', 'eth0_pps_out1', 'eth_extpll_avb', 'eth_phy_reset' do not match any of the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$', '^[a-z]+[0-9]*-gpio-bank$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl.yaml# arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb: pinctrl@16c10000 (samsung,exynosautov920-pinctrl): 'eth0_mdc_mdio', 'eth0_pps_out', 'eth0_rgmii' do not match any of the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$', '^[a-z]+[0-9]*-gpio-bank$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl.yaml# ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-23 6:00 ` [PATCH] arm64: dts: exynos: Added the ethernet pin configuration Yashwant Varur 2025-04-23 8:23 ` Alim Akhtar 2025-04-23 13:37 ` Rob Herring (Arm) @ 2025-04-23 15:11 ` Krzysztof Kozlowski 2025-04-29 9:29 ` Yashwant Varur 2 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-04-23 15:11 UTC (permalink / raw) To: Yashwant Varur, robh, krzk+dt, conor+dt, alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed On 23/04/2025 08:00, Yashwant Varur wrote: > This patch adds the ethernet pin configuration. > > Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> > Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> Incorrect chain or confusing. Who was the author? What is the meaning of the last SoB? > --- > .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > index 663e8265cbf5..778584d339d5 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + eth0_pps_out: eth0_pps_out { Please follow DTS coding style carefully. This applies to all commits you try to send from your downstream/vendor code. What is more important, I don't really understand why you are doing this - there is no user of these entries - and commit msg does not help here. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-23 15:11 ` Krzysztof Kozlowski @ 2025-04-29 9:29 ` Yashwant Varur 2025-04-29 13:07 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Yashwant Varur @ 2025-04-29 9:29 UTC (permalink / raw) To: 'Krzysztof Kozlowski', robh, krzk+dt, conor+dt, alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed -----Original Message----- From: Krzysztof Kozlowski <krzk@kernel.org> Sent: Wednesday, April 23, 2025 8:41 PM To: Yashwant Varur <yashwant.v@samsung.com>; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; niyas.ahmed@samsung.com Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration On 23/04/2025 08:00, Yashwant Varur wrote: > This patch adds the ethernet pin configuration. > > Signed-off-by: Yashwant Varur <yashwant.v@samsung.com> > Signed-off-by: Changsub Lee <cs0617.lee@samsung.com> Incorrect chain or confusing. Who was the author? What is the meaning of the last SoB? > Sorry will correct the order. > --- > .../dts/exynos/exynosautov920-pinctrl.dtsi | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > index 663e8265cbf5..778584d339d5 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi > @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + eth0_pps_out: eth0_pps_out { Please follow DTS coding style carefully. This applies to all commits you try to send from your downstream/vendor code. > Sure, thanks What is more important, I don't really understand why you are doing this - there is no user of these entries - and commit msg does not help here. > Understood, in v2 will add the Ethernet node as well. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-29 9:29 ` Yashwant Varur @ 2025-04-29 13:07 ` Krzysztof Kozlowski 2025-04-30 9:25 ` Yashwant Varur 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-04-29 13:07 UTC (permalink / raw) To: Yashwant Varur, robh, krzk+dt, conor+dt, alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed On 29/04/2025 11:29, Yashwant Varur wrote: > > Please follow DTS coding style carefully. This applies to all commits you try to send from your downstream/vendor code. hm? >> > Sure, thanks > > What is more important, I don't really understand why you are doing this > - there is no user of these entries - and commit msg does not help here. >> > Understood, in v2 will add the Ethernet node as well. I don't understand what is your reply here and what is quote. Use standard email style, not some mySingle or Outlook output. I suggest reading typical guidelines how to use email based workflows (kernel also has one). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration 2025-04-29 13:07 ` Krzysztof Kozlowski @ 2025-04-30 9:25 ` Yashwant Varur 0 siblings, 0 replies; 7+ messages in thread From: Yashwant Varur @ 2025-04-30 9:25 UTC (permalink / raw) To: 'Krzysztof Kozlowski', robh, krzk+dt, conor+dt, alim.akhtar, devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Cc: cs0617.lee, g.naidu, niyas.ahmed Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, April 29, 2025 6:37 PM > To: Yashwant Varur <yashwant.v@samsung.com>; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: cs0617.lee@samsung.com; g.naidu@samsung.com; > niyas.ahmed@samsung.com > Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration > > On 29/04/2025 11:29, Yashwant Varur wrote: > > > > Please follow DTS coding style carefully. This applies to all commits you try to > send from your downstream/vendor code. > > > hm? > Got the issue, coding style says Node and property names can use only the following characters: Lowercase characters: [a-z] Digits: [0-9] Dash: - I was using underscore for node name. > >> > > Sure, thanks > > > > What is more important, I don't really understand why you are doing > > this > > - there is no user of these entries - and commit msg does not help here. > >> > > Understood, in v2 will add the Ethernet node as well. > > I don't understand what is your reply here and what is quote. Use standard email > style, not some mySingle or Outlook output. I suggest reading typical guidelines > how to use email based workflows (kernel also has one). > Looks like mailer was not configured properly, hope this time it is fine. I am working on upstreaming Ethernet driver for exynosauto (which has a variant of STMMAC controller) What I wanted to reply previously was, will add pin control, along with Ethernet node(which will consume the pincontrol) and I realize that first dt-binding should go for this IP. My plan is to send Ethernet driver along with Ethernet dtsi node as well. > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-04-30 10:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250423060042epcas5p2c04be779e21089f33b8a9a7785bb151a@epcas5p2.samsung.com>
2025-04-23 6:00 ` [PATCH] arm64: dts: exynos: Added the ethernet pin configuration Yashwant Varur
2025-04-23 8:23 ` Alim Akhtar
2025-04-23 13:37 ` Rob Herring (Arm)
2025-04-23 15:11 ` Krzysztof Kozlowski
2025-04-29 9:29 ` Yashwant Varur
2025-04-29 13:07 ` Krzysztof Kozlowski
2025-04-30 9:25 ` Yashwant Varur
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).