From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: samsung.c: Add FRACVAL support for newer UART
Date: Wed, 21 Jul 2010 18:20:47 +0900 [thread overview]
Message-ID: <008b01cb28b6$049fc6d0$0ddf5470$%kim@samsung.com> (raw)
In-Reply-To: <4C46B9D8.7020504@ru.mvista.com>
Sergei Shtylyov wrote:
>
> Hello.
>
Hi ;-)
> Kukjin Kim wrote:
>
> > From: Changhwan Youn <chaos.youn@samsung.com>
>
> > FRACVAL register provides the same function as UDIVSLOT register which
is
> > the 1/16ths adjustment to the baud rate but the implementaiton is
easier.
> > To support UDIVSLOT register, UDIVSLOT table search is necessary though
> > supporting FRACVAL only needs the index value of UDIVSLOT table.
>
> > This patch implements the FRACVAL supports for the newer Samsung SoC
> UARTs.
>
> > Signed-off-by: Changhwan Youn <chaos.youn@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> [...]
> > diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
> > index a9d6c56..09805c7 100644
> > --- a/drivers/serial/samsung.c
> > +++ b/drivers/serial/samsung.c
> > @@ -530,7 +530,7 @@ static int s3c24xx_serial_calcbaud(struct baud_calc
*calc,
> >
> > calc->clksrc = clksrc;
> >
> > - if (ourport->info->has_divslot) {
> > + if ((ourport->info->has_divslot) || (ourport->info->has_fracval)) {
>
> Parens around variables are not needed.
>
Yeah.
>
> > @@ -755,7 +758,7 @@ static void s3c24xx_serial_set_termios(struct
uart_port
> *port,
> > wr_regl(port, S3C2410_UBRDIV, quot);
> > wr_regl(port, S3C2410_UMCON, umcon);
> >
> > - if (ourport->info->has_divslot)
> > + if ((ourport->info->has_divslot) || (ourport->info->has_fracval))
>
> Here as well...
>
Yeah.
You're right.
But already re-submitted updated.
Please kindly find following URL.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-July/020713.html
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-07-21 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 13:55 [PATCH] serial: samsung.c: Add FRACVAL support for newer UART Kukjin Kim
2010-07-21 9:11 ` Sergei Shtylyov
2010-07-21 9:20 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008b01cb28b6$049fc6d0$0ddf5470$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox