From mboxrd@z Thu Jan 1 00:00:00 1970 From: j-keerthy@ti.com (Keerthy) Date: Thu, 9 Nov 2017 13:36:48 +0530 Subject: [PATCH v2 2/7] arm: omap: Move dmtimer.h out of plat-omap In-Reply-To: <6ca9c73a-95a1-2466-151e-cdba64c3c478@ti.com> References: <1510144108-29563-1-git-send-email-j-keerthy@ti.com> <1510144108-29563-3-git-send-email-j-keerthy@ti.com> <20171108164221.GV28152@atomide.com> <6ca9c73a-95a1-2466-151e-cdba64c3c478@ti.com> Message-ID: <008c2d8b-6f76-882d-fc70-8fd4204c49d5@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 09 November 2017 09:55 AM, Keerthy wrote: > > > On Wednesday 08 November 2017 10:12 PM, Tony Lindgren wrote: >> * Keerthy [171108 12:31]: >>> The header file is currently under plat-omap directory >>> under arch/omap. Move this out to an accessible place. >>> >>> No Code changes done to the header file. >> >> Some of the dmtimer functions are in this header to optimize the >> size of the system timer code. Can you please check if some of them >> can be left out of dmtimer.h and be made private to mach-omap1/timer.c >> and mach-omap2/timer.c? > > Okay. I will try to clean that as well. Tony, Only function that i could push out of dmtimer.h was __omap_dm_timer_override_errata which is being currently called by mach-omap2/timer.c alone. Rest all are used both my dmtimer.c as well as mach-omap2/timer.c. Here is the list: __omap_dm_timer_read __omap_dm_timer_write __omap_dm_timer_init_regs __omap_dm_timer_enable_posted __omap_dm_timer_stop __omap_dm_timer_load_start __omap_dm_timer_int_enable __omap_dm_timer_read_counter __omap_dm_timer_write_status Any preferences on moving them to dmtimer.c or leaving them in header file? Regards, Keerthy > >> >> Again, we don't want driver code to start mis-using these as that's >> immediately going to be big mess out of control. > > Sure. > >> >> Regards, >> >> Tony >>