From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig
Date: Fri, 13 Aug 2010 18:54:18 +0900 [thread overview]
Message-ID: <009201cb3acd$820678c0$86136a40$%kim@samsung.com> (raw)
In-Reply-To: <20100813083901.GA20285@pengutronix.de>
Uwe Kleine-K?nig wrote:
>
> On Fri, Aug 13, 2010 at 05:15:07PM +0900, Kukjin Kim wrote:
> > This patch fixes on following build warnings.
> >
> > warning: (CPU_S3C2440 && ARCH_S3C2410 && S3C2410_DMA) selects
> S3C2440_DMA which
> > has unmet direct dependencies (ARCH_S3C2410 &&
> CPU_S3C24405B)
> > warning: (CPU_S3C2440 && ARCH_S3C2410 || CPU_S3C2442 &&
> ARCH_S3C2410) selects
> > CPU_S3C244X which has unmet direct dependencies
> (!ARCH_S3C2410)
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > ---
> > arch/arm/mach-s3c2440/Kconfig | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c2440/Kconfig
b/arch/arm/mach-s3c2440/Kconfig
> > index cd8e7de..f60a370 100644
> > --- a/arch/arm/mach-s3c2440/Kconfig
> > +++ b/arch/arm/mach-s3c2440/Kconfig
> > @@ -30,7 +30,7 @@ config CPU_S3C2442
> >
> > config CPU_S3C244X
> > bool
> > - depends on ARCH_S3C2410 && (CPU_S3C2440 || CPU_S3C2442)
> > + depends on (CPU_S3C2440 || CPU_S3C2442)
> > help
> > Support for S3C2440 and S3C2442 Samsung Mobile CPU based
> systems.
> >
> > @@ -72,7 +72,7 @@ config S3C2440_PLL_16934400
> >
> > config S3C2440_DMA
> > bool
> > - depends on ARCH_S3C2410 && CPU_S3C24405B
> > + depends on (ARCH_S3C2410 || CPU_S3C24405B)
> > help
> > Support for S3C2440 specific DMA code5A
> all parenthesis in your +lines are superflous.
>
Yeah, you're right.
Fixed. Thanks. :-)
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2010-08-13 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 8:15 [PATCH] ARM: S3C2410: Fix on build warning about dependency in mach-s3c2440/Kconfig Kukjin Kim
2010-08-13 8:39 ` Uwe Kleine-König
2010-08-13 9:54 ` Kukjin Kim [this message]
2010-08-13 9:57 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009201cb3acd$820678c0$86136a40$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox