linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: undefined reference to `mmc_pm_notify' when selected MMC without PM.
Date: Fri, 13 Aug 2010 19:36:19 +0900	[thread overview]
Message-ID: <009301cb3ad3$77c8a620$6759f260$%kim@samsung.com> (raw)

Hi,

Following is build error when selected MMC without PM.

drivers/built-in.o: In function `mmc_alloc_host':
drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
insert/removal during suspend/resume '
(commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)

Below is temporary patch for avoiding build error.
But I'm not sure about this... :-(

---

diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 0efe631..d80cfdc 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
*dev)
        init_waitqueue_head(&host->wq);
        INIT_DELAYED_WORK(&host->detect, mmc_rescan);
        INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
mmc_host_deeper_disable);
+#ifdef CONFIG_PM
        host->pm_notify.notifier_call = mmc_pm_notify;
+#endif

        /*
         * By default, hosts do not support SGIO or large requests.

---

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

             reply	other threads:[~2010-08-13 10:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 10:36 Kukjin Kim [this message]
2010-08-13 13:14 ` undefined reference to `mmc_pm_notify' when selected MMC without PM Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2010-08-13 11:33 Kukjin Kim
2010-08-16  5:17 ` Uwe Kleine-König
2010-08-16  5:29   ` Kukjin Kim
2010-08-16 15:12   ` Randy Dunlap
2010-08-18  6:38     ` Uwe Kleine-König
2010-08-18  6:48       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009301cb3ad3$77c8a620$6759f260$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).