From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 578C5C47258 for ; Wed, 31 Jan 2024 05:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ERFIpa0rf2Gns2IKCfUA1lMWFA577Yu43rGTFrysfp4=; b=SwJQV/KhOEeqYg /mp6rxP5zMZJaW49waEEwN8XtOIBHnuKws936x3xRa2SeLyWgcSGy6q9TR7rItsVfuBfvnK5fAsQh KosRZr6vx/yaDAd+3la/ZgSjOF8vpTwNWC5QNhvBJ4n/Pds8pZ5Tc1uUtmNiF4zEtuC1vmjD63QiD I9tMUH5HEpyVuCYx0Lz5Cy5FlFwpPPJIOHOVXqoPfdkXHysYGw8vl+K71E6KXZIXzlWX/ZqESFinw hRf+mBThQHWAW6rBKtfsP0st7i2YC6DHu620jw4UDLCFGkxvII4BhdUdv6ly2RDCM2Cvuv7rJ+qHA sfpo/f2i8NDux0ZuF3Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rV2mt-00000001UGC-0Zp2; Wed, 31 Jan 2024 05:05:27 +0000 Received: from mailout1.samsung.com ([203.254.224.24]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rV2mp-00000001UDe-3c6V for linux-arm-kernel@lists.infradead.org; Wed, 31 Jan 2024 05:05:25 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20240131050516epoutp012385ccdcda05549fe972b0bae71a0567~vVii9Ooz_3243332433epoutp01X for ; Wed, 31 Jan 2024 05:05:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20240131050516epoutp012385ccdcda05549fe972b0bae71a0567~vVii9Ooz_3243332433epoutp01X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1706677516; bh=qL3Ay4Pba21ebKmLP4wgOqqtjTV7NsQxQZC9542ZZjY=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=DecoXf+hQ/1V8f4MuFlF9yo32Dbk2T/9Z5muRsTIVYMSCgPBtWWjCMInWaF7/FNPJ tgiDxgf3AJed02x519mN5FUHlK1cvEcn0GmLVoNg5O55yv3/XRGWUaAajHYoYfmqiY 8lKooD6FW7HM0H+od1QGLmDClVXCRQEhbGtFMows= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas5p4.samsung.com (KnoxPortal) with ESMTP id 20240131050516epcas5p47d8730317828176765d0897f441b7e6e~vViiq6zJ30567105671epcas5p4U; Wed, 31 Jan 2024 05:05:16 +0000 (GMT) Received: from epsmgec5p1new.samsung.com (unknown [182.195.38.180]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4TPqjQ3n3kz4x9Pw; Wed, 31 Jan 2024 05:05:14 +0000 (GMT) Received: from epcas5p1.samsung.com ( [182.195.41.39]) by epsmgec5p1new.samsung.com (Symantec Messaging Gateway) with SMTP id BA.59.08567.A05D9B56; Wed, 31 Jan 2024 14:05:14 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20240131050514epcas5p4be8d9e13921fd986fe4575a0e6b1357c~vVigf2yS90107301073epcas5p48; Wed, 31 Jan 2024 05:05:14 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240131050514epsmtrp2abde2bb514eebfd5e4158a59666f7af3~vVigdBfIQ0572005720epsmtrp2E; Wed, 31 Jan 2024 05:05:14 +0000 (GMT) X-AuditID: b6c32a44-617fd70000002177-41-65b9d50a5e2e Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 24.A0.08817.905D9B56; Wed, 31 Jan 2024 14:05:13 +0900 (KST) Received: from INBRO000447 (unknown [107.122.12.5]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240131050511epsmtip154775cf4996d87fa587c78df7e8f1ced~vVidxnqFt2072320723epsmtip1O; Wed, 31 Jan 2024 05:05:11 +0000 (GMT) From: "Alim Akhtar" To: "'Shradha Todi'" , , , , , Cc: , , , , , , , , , , , In-Reply-To: <20240124103838.32478-3-shradha.t@samsung.com> Subject: RE: [PATCH v4 2/2] PCI: exynos: Adapt to clk_bulk_* APIs Date: Wed, 31 Jan 2024 10:35:10 +0530 Message-ID: <009c01da5403$12b926d0$382b7470$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIcpPks/WB953w72Rl3v8cfkz9jJgIOwv9MAllxpn6wS3ptMA== Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA02Te0xbZRjG+XoHxZwVyD6KznIMYzCBVgocBmyDgTvKEjDEJZooO6EnlFBO m152M5uddMxdQEDIRhmTFsKwyBiFymWwAbsgIEHCVnDKlJuZI4AbWDAwsO3ZlP9+7/c+T57v /S48Jn+GI+BlURpSRRFylOPB+v52UGCIx4M2UmT8yg+r/kKG1S6VcbHOWSsX011YZWOWKRsb e3rhERsbab/MwQav9HKwS0M3GVhPaSfA9Gt6FlZ/Z5yLjevPsrHh/iTMZF3iYhsdrVxs3dbI wvJvn9jLx0dsw0x8Yew0F28zjHPxSosWt5jPcvBfbR0cfPr+RQbeVP05XtBsBviiZVuqx8fZ sTKSkJIqIUllKKRZVGYcmpyWvi89IlIkDhFHY1GokCJyyDg08UBqyLtZcsdEqPAwIdc6llIJ tRoN2x2rUmg1pFCmUGviUFIplSslylA1kaPWUpmhFKnZJRaJ3olwCA9lyyYry5nKDfTo4q1B hg48f/0ccOdBRAJHbd3AyXzkBoB9E0dpfgbgpFV6Dng42A5g6e/lnJeGurZGNt3oBHD5+R8c ungMoGFqiOtUcZAQ2FqV52p4I6MALi2bWc6CidxgwLn2FVegOxIDJ6t7mE72QuLhY/vXLmYh AdB0a4TtZE8kGhaUDrBo3gL7yqZdzER2whrjLJPekxD+M1Pj0nsjCXChto5Da7bCP+/e4TqD IbLBg7PFl1i0IRGWjAy8MHvBJ73NXJoFcHG+02HmORiHpjUBvSyDc1cbAM17YNf9yyynhIkE wYb2MDrqNZi/Os2gnZ7wyzw+rQ6AufMPXoT6waLz59k04zDP/oRTCPwNmwYzbBrMsGkAw/9h lYBlBr6kUp2TSWZEKMUUeeS/+85Q5FiA670HJ7aCsW/WQ3sAgwd6AOQxUW/Pb7e1kXxPKXHs OKlSpKu0clLdAyIcp13EFPhkKBwfhtKkiyXRIklkZKQkOjxSjG71nD1dIeUjmYSGzCZJJal6 6WPw3AU6hq95vWqitj9+/MdjQabc7Vla4Z78h7+EBM4UuX04vvdwxILeS1xQfBN/76mv36Dg 4FsnT5bsC89utK4kdu3W/vATdQ33f9acNCNJfVNwKD1+LbG7cAXvqCqLsjE+6Ky2G4dMxrdb djwK3tFb6nY9bCgZpNUn7S/W/XWxrXG95VURNexjuZISc0Qyub0ld3VN98oJ6mdtytjDxYnC Nz4rqbib0Tyv/7RVMFATk7M8F+7vZp/L3WUt6K0/OFNo/u5UH9tny73QhWKiXldR3tFckHYm wNiYMBp44NTfpoCm/pSue1PvD8+zric07LzKLpo1dp+5Vpf8CRFrbtKjvx2Xy6LsH+1HWWoZ IQ5mqtTEv6KRjfJ4BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWy7bCSnC7n1Z2pBveuWFksacqwWPFlJrvF 3tdb2S0aen6zWmx6fI3V4mPPPVaLy7vmsFmcnXeczWLG+X1MFoem7mW0aPnTwmKx9shddou7 LZ2sFhdPuVos2vqF3eL/nh3sFv+ubWSx6D1c6yDkcfnaRWaP9zda2T12zrrL7rFgU6nHplWd bB53ru1h83hyZTqTx+Yl9R59W1YxenzeJBfAFcVlk5Kak1mWWqRvl8CVcaBpCWvBLcWKfZ+2 MjcwXpPuYuTkkBAwkVi9cyNrFyMXh5DAbkaJ5n+TmSES0hLXN05gh7CFJVb+e84OUfSMUWLS /yZGkASbgK7EjsVtbCAJEYG7jBKNy/+AdTALnGSSmDdfBW7ssgNnWEASnALWEo+WHAJbISzg KPHiG8Q6FgFViUX7L7OC2LwClhJ9U0+zQNiCEidnPmGBGKot0fuwlRHGXrbwNdSpChI/ny4D 6xURcJJ4v2I1G0SNuMTLo0fYJzAKz0IyahaSUbOQjJqFpGUBI8sqRsnUguLc9NxiwwKjvNRy veLE3OLSvHS95PzcTYzgSNfS2sG4Z9UHvUOMTByMhxglOJiVRHhXyu1MFeJNSaysSi3Kjy8q zUktPsQozcGiJM777XVvipBAemJJanZqakFqEUyWiYNTqoEpwiLDRv6GcOpx0cLzq4rPmv/Q e7L03ILZVu2bL9jURavcFHbZNoeNdwlPuMb/jQ+6GWo1v4QfmlOQqXx+4tbmP+eUzM8ph37d FqrK61x+mPN1WOFPqYTbfKbrgxddPSPe5S7S98n0S+Pv0w9+VJVKuq5u5N3I8vfPwxlBX851 O9pP5ro6aZpj5IWZvrIlHR7rjxuGaFdmX9Hc0TtRn/HX3+BnRuJ+0ctfvs2a0javRVuk/MnD k7aiBseyDvseqN378wpjqPMr9YkH7uwJMXSN2HhRPaN+qsChffGuLdtuaQfOijeSPRkQ1K5c eVlU7/Fjpg9eez768x9nenNtg9/x88cjL5n9u5Z1XLdWuZpDiaU4I9FQi7moOBEAYH66VWMD AAA= X-CMS-MailID: 20240131050514epcas5p4be8d9e13921fd986fe4575a0e6b1357c X-Msg-Generator: CA CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240124103858epcas5p3d96cdbe8a6c8f31ccc934025411a09b8 References: <20240124103838.32478-1-shradha.t@samsung.com> <20240124103838.32478-3-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_210524_272388_99A4ECD7 X-CRM114-Status: GOOD ( 25.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Shradha > -----Original Message----- > From: Shradha Todi > Sent: Wednesday, January 24, 2024 4:09 PM > To: linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org > Cc: mturquette@baylibre.com; sboyd@kernel.org; jingoohan1@gmail.com; > lpieralisi@kernel.org; kw@linux.com; robh@kernel.org; > bhelgaas@google.com; krzysztof.kozlowski@linaro.org; > alim.akhtar@samsung.com; linux@armlinux.org.uk; > m.szyprowski@samsung.com; manivannan.sadhasivam@linaro.org; > pankaj.dubey@samsung.com; Shradha Todi > Subject: [PATCH v4 2/2] PCI: exynos: Adapt to clk_bulk_* APIs > > There is no need to hardcode the clock info in the driver as driver can rely on > the devicetree to supply the clocks required for the functioning of the > peripheral. Get rid of the static clock info and obtain the platform supplied > clocks. All the clocks supplied is obtained and enabled using the > devm_clk_bulk_get_all_enable() API. > > Signed-off-by: Shradha Todi > --- Reviewed-by: Alim Akhtar > drivers/pci/controller/dwc/pci-exynos.c | 54 ++----------------------- > 1 file changed, 4 insertions(+), 50 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-exynos.c > b/drivers/pci/controller/dwc/pci-exynos.c > index ec5611005566..3234eb5be1fb 100644 > --- a/drivers/pci/controller/dwc/pci-exynos.c > +++ b/drivers/pci/controller/dwc/pci-exynos.c > @@ -54,43 +54,11 @@ > struct exynos_pcie { > struct dw_pcie pci; > void __iomem *elbi_base; > - struct clk *clk; > - struct clk *bus_clk; > + struct clk_bulk_data *clks; > struct phy *phy; > struct regulator_bulk_data supplies[2]; > }; > > -static int exynos_pcie_init_clk_resources(struct exynos_pcie *ep) -{ > - struct device *dev = ep->pci.dev; > - int ret; > - > - ret = clk_prepare_enable(ep->clk); > - if (ret) { > - dev_err(dev, "cannot enable pcie rc clock"); > - return ret; > - } > - > - ret = clk_prepare_enable(ep->bus_clk); > - if (ret) { > - dev_err(dev, "cannot enable pcie bus clock"); > - goto err_bus_clk; > - } > - > - return 0; > - > -err_bus_clk: > - clk_disable_unprepare(ep->clk); > - > - return ret; > -} > - > -static void exynos_pcie_deinit_clk_resources(struct exynos_pcie *ep) -{ > - clk_disable_unprepare(ep->bus_clk); > - clk_disable_unprepare(ep->clk); > -} > - > static void exynos_pcie_writel(void __iomem *base, u32 val, u32 reg) { > writel(val, base + reg); > @@ -332,17 +300,9 @@ static int exynos_pcie_probe(struct platform_device > *pdev) > if (IS_ERR(ep->elbi_base)) > return PTR_ERR(ep->elbi_base); > > - ep->clk = devm_clk_get(dev, "pcie"); > - if (IS_ERR(ep->clk)) { > - dev_err(dev, "Failed to get pcie rc clock\n"); > - return PTR_ERR(ep->clk); > - } > - > - ep->bus_clk = devm_clk_get(dev, "pcie_bus"); > - if (IS_ERR(ep->bus_clk)) { > - dev_err(dev, "Failed to get pcie bus clock\n"); > - return PTR_ERR(ep->bus_clk); > - } > + ret = devm_clk_bulk_get_all_enable(dev, &ep->clks); > + if (ret < 0) > + return ret; > > ep->supplies[0].supply = "vdd18"; > ep->supplies[1].supply = "vdd10"; > @@ -351,10 +311,6 @@ static int exynos_pcie_probe(struct platform_device > *pdev) > if (ret) > return ret; > > - ret = exynos_pcie_init_clk_resources(ep); > - if (ret) > - return ret; > - > ret = regulator_bulk_enable(ARRAY_SIZE(ep->supplies), ep- > >supplies); > if (ret) > return ret; > @@ -369,7 +325,6 @@ static int exynos_pcie_probe(struct platform_device > *pdev) > > fail_probe: > phy_exit(ep->phy); > - exynos_pcie_deinit_clk_resources(ep); > regulator_bulk_disable(ARRAY_SIZE(ep->supplies), ep->supplies); > > return ret; > @@ -383,7 +338,6 @@ static int __exit exynos_pcie_remove(struct > platform_device *pdev) > exynos_pcie_assert_core_reset(ep); > phy_power_off(ep->phy); > phy_exit(ep->phy); > - exynos_pcie_deinit_clk_resources(ep); > regulator_bulk_disable(ARRAY_SIZE(ep->supplies), ep->supplies); > > return 0; > -- > 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel