From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor@kernel.org>, Chen-Yu Tsai <wenst@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: arm: mediatek: Add MT8186 Tentacruel / Tentacool Chromebooks
Date: Fri, 20 Oct 2023 11:12:49 +0200 [thread overview]
Message-ID: <00a64eaa-0e6d-419a-a54f-d67fe2b60a7b@linaro.org> (raw)
In-Reply-To: <20231018-earpiece-dimmed-81c0f728d0b6@spud>
On 18/10/2023 17:07, Conor Dooley wrote:
>>> Then it seems like what you need is something like
>>> oneOf:
>>> - items:
>>> - const: google,tentacruel-sku262144
>>> - const: google,tentacruel
>>> - const: mediatek,mt8186
>>> - items:
>>> - enum:
>>> - google,tentacruel-sku262145
>>> - google,tentacruel-sku262146
>>> - google,tentacruel-sku262147
>>> - const: google,tentacruel-sku262144
>>> - const: google,tentacruel
>>> - const: mediatek,mt8186
>>>
>>> What you have at the moment just seems like a hack because you want to
>>> stuff all of these compatible strings into a single dts.
>>
>> It is. And it works OK downstream. The reason we want to stuff them in
>> one dts is because the firmware will not generate the fallback to
>> sku262144 as the scheme above suggests.
>
> I'm not going to ack the hack that you have here, sorry. Maybe Rob or
> Krzysztof will. The list your firmware generates above doesn't even
> match the contents of this patch, with the extra "rev-4" compatibles.
No Acks from me either... Chromebooks board compatibles are a long
standing confusion for me and every time I forget why this is so
counter-intuitively. My comments for changing this were rather receiving
feedback "but our firmware likes it that way".
OTOH, board compatibles just have to be unique, so we could accept some
weird, counter-intuitive combinations... but it does not mean I should
be happy with them.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-20 9:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 23:02 [PATCH 0/9] arm64: dts: mediatek: Add MT8186 Corsola Chromebooks Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 1/9] dt-bindings: arm: mediatek: Sort entries by SoC then board compatibles Chen-Yu Tsai
2023-10-13 15:04 ` Conor Dooley
2023-10-12 23:02 ` [PATCH 2/9] dt-bindings: arm: mediatek: Add MT8186 Tentacruel / Tentacool Chromebooks Chen-Yu Tsai
2023-10-13 15:11 ` Conor Dooley
2023-10-13 17:29 ` Chen-Yu Tsai
2023-10-13 17:55 ` Conor Dooley
2023-10-13 18:19 ` Chen-Yu Tsai
2023-10-14 13:40 ` Conor Dooley
2023-10-16 6:15 ` Chen-Yu Tsai
2023-10-18 15:07 ` Conor Dooley
2023-10-20 9:12 ` Krzysztof Kozlowski [this message]
2023-10-20 10:06 ` Chen-Yu Tsai
2023-11-24 14:08 ` Conor Dooley
2023-11-27 2:23 ` Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 3/9] dt-bindings: arm: mediatek: Add MT8186 Steelix Chromebook Chen-Yu Tsai
2023-10-13 15:12 ` Conor Dooley
2023-10-12 23:02 ` [PATCH 4/9] dt-bindings: arm: mediatek: Add MT8186 Rusty Chromebook Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 5/9] dt-bindings: arm: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 6/9] arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool Chen-Yu Tsai
2023-10-16 9:19 ` AngeloGioacchino Del Regno
2023-10-16 22:09 ` Chen-Yu Tsai
2023-10-16 9:21 ` Eugen Hristev
2023-10-16 17:12 ` Chen-Yu Tsai
2023-10-23 9:05 ` Eugen Hristev
2023-11-27 4:00 ` Chen-Yu Tsai
2023-11-27 13:05 ` AngeloGioacchino Del Regno
2023-12-01 15:32 ` Eugen Hristev
2023-10-12 23:02 ` [PATCH 7/9] arm64: dts: mediatek: Introduce MT8186 Steelix Chen-Yu Tsai
2023-10-16 8:36 ` Eugen Hristev
2023-11-27 3:56 ` Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 8/9] arm64: dts: mediatek: Add MT8186 Steelix platform based Rusty Chen-Yu Tsai
2023-10-12 23:02 ` [PATCH 9/9] arm64: dts: mediatek: Add MT8186 Magneton Chromebooks Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a64eaa-0e6d-419a-a54f-d67fe2b60a7b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).