From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3x24xx: Fix gpiochip_add complaining.
Date: Thu, 25 Nov 2010 16:15:08 +0900 [thread overview]
Message-ID: <00b201cb8c70$7ff96e30$7fec4a90$%kim@samsung.com> (raw)
In-Reply-To: <201011191253.58812.anarsoul@gmail.com>
Vasily Khoruzhick wrote:
>
> On Friday 19 November 2010 12:42:02 Lars-Peter Clausen wrote:
> > Hi
> >
Hi all,
> > Well it actually causes problems on systems with external gpio
expanders,
> > because now the additional banks will take up the space which was meant
> > for the gpio expander chip and peripherals connected to it wont be
> > accessible.
>
> Ok, but it would be nice to see some runtime soc-type detection for
gpiolib.
Yeah, I agree. We need to check SoC type for it during booting...
> s3c2410/s3c2440/s3c2442 doesn't differ too much (actually, they're same in
> gpiopart, s3c2410 lacks some gpiobanks that s3c244[0,2] have, and
difference
> in pull-up/pull-down on s3c2440 and s3c2442).
> I think it's not good to make artificial restrictions for building single
> binary kernel for these socs.
>
> > I sent a patch[1] about this some time ago, but I guess it was never
> > applied...
Maybe you missed my e-mail...or..I missed?...anyway...
Could you please re-send it so that can get the patch via e-mail?
>
> Try pinging Ben or Kukjin :)
>
Thanks...
Basically, I'd like to keep single binary for S3C24XX, maybe Ben also agree
with this. But also there is some side effects, i.e., according to
mach-s3c2410/Makefile.boot, zreladdr is different. But only selected
0x30108000 as zreladdr when build time because selected CONFIG_PM_H1940 with
s3c2410_defconfig if there is no changes kernel configuration. This is just
simple example. Maybe There are many similar examples.
Hmm...anyway, we need to sort it out with keeping S3C24XX single binary.
Will think some method for this...
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-11-25 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 9:15 [PATCH] ARM: s3x24xx: Fix gpiochip_add complaining Marek Belisko
2010-11-19 9:23 ` Vasily Khoruzhick
2010-11-19 10:42 ` Lars-Peter Clausen
2010-11-19 10:53 ` Vasily Khoruzhick
2010-11-25 7:15 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b201cb8c70$7ff96e30$7fec4a90$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).