From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E00BCA0EE4 for ; Sat, 23 Aug 2025 09:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=asCGKjBvcLIXcXUvTDB/pRmft2VEgqJkRU+ozd+V3kw=; b=GOmJHW6dkdhB2uwqcwmrAilYp2 aKkOh6zxAPOiyjxK+2rZN7xDt7av6fLbFeZ45jvwIsniJxN/isURbhCd/THDWpAoEHUCWVyx7tyQy Je3hIhksiHsL4GRI7pPvAqQEWcGAdaYDtSedCp+Dt/WuQgD+VHoho049CDnd8i+yxqBZunti4R2rJ f4HmarM9S2WBO4Z5c/AQ9hIIk8qICPrOVdD7RbbAFQ35qCT+ZBY93Cpxn/OY6d4EfQa+tgf2hR3jN +z1hTpBY9Z1v1/HnVxZKKstf7X/CEXfXtYr8Ik0muq4iQzhQLipyv8/leQ6QxyxNLQ11/yD25Fwz6 ekT4F27A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upkgm-00000004X8Q-1roI; Sat, 23 Aug 2025 09:37:32 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1updTO-00000003mkS-3Owc for linux-arm-kernel@lists.infradead.org; Sat, 23 Aug 2025 01:55:17 +0000 Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20250823015505epoutp02da4ff67e154b62c54b6b85c4e82cacc4~eQpNQetWJ0382003820epoutp02P for ; Sat, 23 Aug 2025 01:55:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20250823015505epoutp02da4ff67e154b62c54b6b85c4e82cacc4~eQpNQetWJ0382003820epoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1755914105; bh=asCGKjBvcLIXcXUvTDB/pRmft2VEgqJkRU+ozd+V3kw=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=uc7Egc9knMcegX8j9Ul8mLWHa6t1jfGt6qQY2GMWWC/IRukYxrJk0iO9lvX26z0X7 d2yWSk23ksCEUfCloabZ9I/u0ESTMG9ld+hUsO50JW2D5rV+7ceQy1InglVFew1i6L hTp3o5jIkBoIs2K8XljStzZIPU2NFdcHVoz9Sx0o= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPS id 20250823015503epcas5p4f37cf633ec897cf5cab6117f191d17a5~eQpLZM0vF1982919829epcas5p4q; Sat, 23 Aug 2025 01:55:03 +0000 (GMT) Received: from epcas5p2.samsung.com (unknown [182.195.38.86]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4c80Vt1xfPz6B9m6; Sat, 23 Aug 2025 01:55:02 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20250823015501epcas5p2edc67128fded208772b700d6b811c948~eQpJfftO53272832728epcas5p2D; Sat, 23 Aug 2025 01:55:01 +0000 (GMT) Received: from FDSFTE196 (unknown [107.116.189.214]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250823015457epsmtip1ec063c01134a62dda47169229eba2da7~eQpFx0Y6c0879208792epsmtip17; Sat, 23 Aug 2025 01:54:57 +0000 (GMT) From: "Inbaraj E" To: "'Krzysztof Kozlowski'" , , , , , , , , , , , , , , , , , , , Cc: , , , , , , , , , , In-Reply-To: <67199625-13d2-4510-bbbd-3dd2f61c62fd@kernel.org> Subject: RE: [PATCH v2 10/12] dt-bindings: media: fsd: Document CSIS DMA controller Date: Sat, 23 Aug 2025 07:24:55 +0530 Message-ID: <00d301dc13d0$efb4ef90$cf1eceb0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQK5oFMD+tt4mLQU5V9KgVyIDaUIUQIMxZSZAiExi2YBbREwJ7KHhpcw Content-Language: en-in X-CMS-MailID: 20250823015501epcas5p2edc67128fded208772b700d6b811c948 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-541,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250814141051epcas5p14dccee388087372973988aeebcb872cf References: <20250814140943.22531-1-inbaraj.e@samsung.com> <20250814140943.22531-11-inbaraj.e@samsung.com> <67199625-13d2-4510-bbbd-3dd2f61c62fd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250822_185515_170965_3F62F403 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for the review. > > On 14/08/2025 16:09, Inbaraj E wrote: > > Document bindings for the FSD CSIS DMA controller. > > > > Signed-off-by: Inbaraj E > > --- > > .../bindings/media/tesla,fsd-csis-media.yaml | 74 > > +++++++++++++++++++ > > Your patchset is organized in total mess. First clock, then media bindings, > then arm64, then media drivers, then media bindings, then arm64... Please > organize it in standard way - about independent subsystems I mentioned, so > within media first bindings, then driver. Not intermixed. I'll update in next patchset. > > > > > 1 file changed, 74 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml > > new file mode 100644 > > index 000000000000..ce6c2e58ed4e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/tesla,fsd-csis- > media.yam > > +++ l > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=21cb70d9-4129ed84-21cafb96- > 000b > > +abd9f1ba-63c99c5193b8964e&q=1&e=f7087d49-8d33-4468-9323- > 67fa9fa72e40& > > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fmedia%2Ftesla%2Cfsd- > csis-me > > +dia.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=4db8909d-2d5a0dc0-4db91bd2- > 000b > > +abd9f1ba-be3588ecc45596c1&q=1&e=f7087d49-8d33-4468-9323- > 67fa9fa72e40& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Tesla FSD SoC MIPI CSI-2 DMA (Bridge device) receiver > > + > > +maintainers: > > + - Inbaraj E > > + > > +description: |- > > Drop |- > > > + The FSD MIPI CSI-2 (Camera Serial Interface 2) have internal DMA > > + engine to capture frames originating from the sensor. > > + > > +properties: > > + compatible: > > + const: tesla,fsd-csis-media > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: aclk > > + - const: pclk > > + - const: pll > > + > > + iommus: > > + maxItems: 1 > > + > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > Don't you need second port to CSIS block? No, one port is sufficient. This port represent CSIS DMA and connected to CSIS (imx-mipi-csis node) I guess this one is input from the > sensor? No, it is input from CSIS(imx-mipi-csis). Regards, Inbaraj E