* [PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv
@ 2011-09-22 21:08 Heiko Stübner
2011-09-26 4:26 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stübner @ 2011-09-22 21:08 UTC (permalink / raw)
To: linux-arm-kernel
The changed statement should set the old armdiv bits to 0
and not everything else, before setting the new value.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/mach-s3c2443/clock.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
index 966bde5..27549c4 100644
--- a/arch/arm/mach-s3c2443/clock.c
+++ b/arch/arm/mach-s3c2443/clock.c
@@ -124,7 +124,7 @@ static int s3c2443_armclk_setrate(struct clk *clk, unsigned long rate)
unsigned long clkcon0;
clkcon0 = __raw_readl(S3C2443_CLKDIV0);
- clkcon0 &= S3C2443_CLKDIV0_ARMDIV_MASK;
+ clkcon0 &= ~S3C2443_CLKDIV0_ARMDIV_MASK;
clkcon0 |= val << S3C2443_CLKDIV0_ARMDIV_SHIFT;
__raw_writel(clkcon0, S3C2443_CLKDIV0);
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv
2011-09-22 21:08 [PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv Heiko Stübner
@ 2011-09-26 4:26 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2011-09-26 4:26 UTC (permalink / raw)
To: linux-arm-kernel
Heiko St?bner wrote:
>
> The changed statement should set the old armdiv bits to 0
> and not everything else, before setting the new value.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/mach-s3c2443/clock.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> index 966bde5..27549c4 100644
> --- a/arch/arm/mach-s3c2443/clock.c
> +++ b/arch/arm/mach-s3c2443/clock.c
> @@ -124,7 +124,7 @@ static int s3c2443_armclk_setrate(struct clk *clk,
unsigned
> long rate)
> unsigned long clkcon0;
>
> clkcon0 = __raw_readl(S3C2443_CLKDIV0);
> - clkcon0 &= S3C2443_CLKDIV0_ARMDIV_MASK;
> + clkcon0 &= ~S3C2443_CLKDIV0_ARMDIV_MASK;
> clkcon0 |= val << S3C2443_CLKDIV0_ARMDIV_SHIFT;
> __raw_writel(clkcon0, S3C2443_CLKDIV0);
> }
> --
> 1.7.2.3
Hi Heiko,
Yes, you're right.
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-26 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-22 21:08 [PATCH] S3C2443: Fix bit-reset in setrate of clk_armdiv Heiko Stübner
2011-09-26 4:26 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).