From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE131C433FE for ; Wed, 2 Nov 2022 19:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nQb77XGuf+2eMtmrdVXYUq8Qb3wBQ71c6kAt1e0sZfA=; b=N88/kmQpoyCp/S /TZ6w2M5LhDigHPPMcdn9DmW4/wE7z0Tt51HHtYYg4YaFPN214k9ANZKoHTBdmrUaBscSU4f1yMAH 2DDCQvKNtnBo/Ld7eHrBgZJ6fVCSe0QK98yUQtEyc/Vt1G3H6mR95ewZh/oTYupUaf11nYfkPXKYU oPg1LySgeczzBjB/ouj8YqpKGtfBia0X3uX2v+YgHyizdYAxeg4fTJYMQvPr1Wp2U2vFOal9apWyw /vKmkGTFXzX1Z38XeR1wprF1VVQD5sc4qOSpjjBZvz1OK80FTtMUaRiuvhBHkvQCXxW8A8TYV5l9j U2pubAOcHmhThmmBtwEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqJq3-00E6DX-Ed; Wed, 02 Nov 2022 19:55:51 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqJq0-00E6Bo-FT for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 19:55:50 +0000 Received: by mail-qt1-x82e.google.com with SMTP id l15so197qtv.4 for ; Wed, 02 Nov 2022 12:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bvp0GxHXX02PA4c6ttDiy9yeQr8r+U10bXzzBfuTgfg=; b=MUcHdRuPKLmFMKrd7RgK1QXx6B0CeD6S6Ej/TAQWrSPf26ox3BeLiD5lO68CVkeOGR 73uHUGRPGWcEQoPhOAg5IwR9rhxIB0aoRWe5/DPmGaswZJ1TIg/zOdPhhQJnkU14YLy0 344yTQ3F7JbJRIItjVwfyKzwp7rqiBZVPhe3yIjXEM4uwqZWWY+D5hDS9mEeDjA1MVEF yuUzyyV+1L9wjq+2M50waxbbw3K1iInyT0VLJBypwigCQUpwGkXAHv8wfz8fuEisoiMM NggB12ea3SXcVBwPAK8Vo+8M6i/uNTnIaPP5DaWDZmUFB/XVvG2+8KiHT6pb4O49RWlB q2jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bvp0GxHXX02PA4c6ttDiy9yeQr8r+U10bXzzBfuTgfg=; b=aRLXQ9/daLSkYqp4ALx2U+f9di/2y6mIPN1HSXgQYjbmupXCxBPbOdyC6YosrwMpAt HSvw8qvYDWbU7ouDChLgPkJ/mSNNLEc2qTejkhe2PvcF+4IDUnfja3t5GDcf1hzcCpPD GHjgR91L3cCHpn1+MZ/J+Ya/F1g7JhVUan9GVZUUZ7ohlEpZemMy1aDv4243Vou1jJ90 cIEa3SVJ9ma7OHbBFFffUlDpF0UUpNR0WA5wXKwnz+uUL+Fmtvv2WrayRbneV2o16sjB Ec1/TKAObVzukgwKZGZ7PnWgHI4g/F2pNAN0Q4u5dAQy6xvs4X4Eb1EAn15w8j5b8Aix vtOA== X-Gm-Message-State: ACrzQf2Zdp/6DXjXe5OF+mrwnsvTs83M+OUi65hOTByH6VJgRLKEGwYR rNgqE2Pubj/jXEY61Z4TVDs9qQ== X-Google-Smtp-Source: AMsMyM6QWbjr326dSXQCPiL6JFeXTSgexxMZLfP1Di29Ar8lXTBavHU5SJ7uP/DBriEaFq7FWdpcJQ== X-Received: by 2002:a05:622a:11c4:b0:39c:d88e:dc93 with SMTP id n4-20020a05622a11c400b0039cd88edc93mr21317995qtk.332.1667418945704; Wed, 02 Nov 2022 12:55:45 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:28d9:4790:bc16:cc93? ([2601:586:5000:570:28d9:4790:bc16:cc93]) by smtp.gmail.com with ESMTPSA id bm8-20020a05620a198800b006ed138e89f2sm9142744qkb.123.2022.11.02.12.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 12:55:45 -0700 (PDT) Message-ID: <00dd8dc0-2f8c-753e-2109-1b30154c38c2@linaro.org> Date: Wed, 2 Nov 2022 15:55:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] arm64: dts: Add support for phyBOARD-Electra-AM642 Content-Language: en-US To: Nishanth Menon , Wadim Egorov Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "vigneshr@ti.com" , "kristo@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" References: <20221102134923.3438022-1-w.egorov@phytec.de> <20221102134923.3438022-2-w.egorov@phytec.de> <20221102151047.ucwh7dwmmqhx4nxf@rejoice> <1c73c3a0-458a-0005-f9a7-2d879e70cfe3@phytec.de> <20221102194146.zyaw2yzl7q4b6r7u@ducky> From: Krzysztof Kozlowski In-Reply-To: <20221102194146.zyaw2yzl7q4b6r7u@ducky> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_125548_551922_142C42FC X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/11/2022 15:41, Nishanth Menon wrote: > On 16:56-20221102, Wadim Egorov wrote: > [...] > >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +/ { >>>> + model = "PHYTEC phyCORE-AM64x"; >>>> + compatible = "phytec,am64-phycore-som"; >>> Does this match the binding? >> >> Not very sure about the compatible I should chose here. It is probably not very >> important since the compatible gets overridden by the carrier which specifies >> the am642 SoC. >> Seems like the TI SoMs (k3-j7*som*.dtsi) do not add a compatible at all. >> >> Or do you think we should add the "ti,am642" compatible here? > > If the compatible of SoM makes much sense as a standalone OR usable > elsewhere, then it could be an enum option to allow for som, soC as a > valid combination. > > On the other hand, simplistically, it does look like SoM (like the j7es > processor board) serves no specific purpose standalone, in which case > skipping it is more appropriate. The compatible from patch is clearly wrong - you cannot have such compatible alone. Whether having there compatible at all, is a different question... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel