From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3F6DC7115A for ; Wed, 18 Jun 2025 17:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zSdGgQ164VaLH+mm2XZdxVC+s9AToDzIeoD3uE9jAfo=; b=oH2k7EHca+e2usAFinIHL2lZso oIO7ikqULdKRfGcfEZ/8bDrRqIkX0xHJN1n6htOh5u88RDhyj8oyTR0JiTn8SA03B3MRb1lzoHxrs z/I/IvzsndnDCbEGMpswAAwEc4URhuAfMnaw7xdgvArIaeCiegg5yJtkrIf8wKwhjHKgtBnzwraiW GsQwju5TGOfGt6xN4uzUQoLQZJi1VhpfGjCqokbrZS7B3tJLJiJgWW8hvtOZ1tjpZrVqd6iGD8BT2 oz7dVSGcTkH7zV3eaJMA+BxtAFInn1YT6AUrjMYi7HAnWifkhYx9E4IZKNGNW3Bo8/hsUDJcgZwY4 Pf2wn22Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRwKp-0000000Aor2-3W2Z; Wed, 18 Jun 2025 17:12:27 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRuth-0000000Acdh-3DSY for linux-arm-kernel@lists.infradead.org; Wed, 18 Jun 2025 15:40:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E51F1A52449; Wed, 18 Jun 2025 15:40:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 179F5C4CEEF; Wed, 18 Jun 2025 15:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750261220; bh=HsoAbQnBnE/foxpNITtdHMz0c3PnR0dNcIrv20ad6LI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TdRdKtCCpUvEcRzN6UVw/ncdpT6sNXiKqW3TCav3FB7V2y5/lG0FkJEORT0X3UgnS BZxkfqfvM8cwqvty7aUK0wAV25tZzs5obxqCX+yUcS8awsjDUe6+FwETA6v94/rYCe tYsnosi+8ofmyjkNOxwNi5Lm48+pPJKpx1MAruTlTAxCOXnryqVr4rUQGMtUUgrUgx OXxCsXrs8ASo43uVOnWuPmdViVRgeBOmH6liEmmUr0uUk5ci92gVhoFQG3YKGkDLTq wBq6z7we2eWMuYRdxW/xUrlct1dklu7m+knE/PUWmfcqcUFmxs2KD2XGjULDd9szH5 uqXQ96kzdVPbw== Message-ID: <00e28a4a-78d6-4452-b28f-29d2e201f6d9@kernel.org> Date: Wed, 18 Jun 2025 17:40:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs To: Kaustabh Chakraborty Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org> <20250612-exynos7870-drm-dts-v1-1-88c0779af6cb@disroot.org> <7bb375c8-1a43-40e2-891c-8815c9cc94ff@kernel.org> <76df5b2d6b2c8de73519e1862e105c67@disroot.org> <97a54a9f-8719-4bbd-a1d5-dd398f42ab0c@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250618_084021_945052_E2893232 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/06/2025 16:49, Kaustabh Chakraborty wrote: > On 2025-06-18 14:37, Krzysztof Kozlowski wrote: >> On 18/06/2025 16:32, Kaustabh Chakraborty wrote: >>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote: >>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote: >>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs >>>>> are >>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks. >>>>> >>>>> Signed-off-by: Kaustabh Chakraborty >>>>> --- >>>>> .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> index >>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 >>>>> 100644 >>>>> --- >>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> +++ >>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml >>>>> @@ -52,6 +52,12 @@ properties: >>>>> - samsung,exynosautov9-sysreg >>>>> - const: syscon >>>>> deprecated: true >>>>> + - items: >>>>> + - enum: >>>>> + - samsung,exynos7870-cam-sysreg >>>>> + - samsung,exynos7870-disp-sysreg >>>>> + - const: samsung,exynos7870-sysreg >>>> >>>> >>>> Drop. These are not really compatible or your commit msg is >>>> incomplete. >>>> Don't use deprecated syntax and backwards compatible solutions for >>>> new >>>> hardware. >>> >>> Are you sure? The deprecated one is actually the item above. From what >>> I >> >> Yes. Think why were they added. >> >>> understand, those are generic sysregs and don't mention their >>> functions. >> >> And what is a generic sysreg? > > What I meant is, usually compatibles go like this (in order): No, they don't. So you checked why they were added? Best regards, Krzysztof