From: Krzysztof Kozlowski <krzk@kernel.org>
To: Huan Tang <tanghuan@vivo.com>,
srini@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: imx-ocotp: Use helper function devm_clk_get_enabled()
Date: Tue, 24 Jun 2025 08:50:35 +0200 [thread overview]
Message-ID: <00e76ce2-126a-40ab-badd-210a20041843@kernel.org> (raw)
In-Reply-To: <20250624032318.246-1-tanghuan@vivo.com>
On 24/06/2025 05:23, Huan Tang wrote:
> Use devm_clk_get_enabled() helper to simplify code.
>
> Signed-off-by: Huan Tang <tanghuan@vivo.com>
> ---
> drivers/nvmem/imx-ocotp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
> index 79dd4fda0329..ce5970ba4033 100644
> --- a/drivers/nvmem/imx-ocotp.c
> +++ b/drivers/nvmem/imx-ocotp.c
> @@ -605,7 +605,7 @@ static int imx_ocotp_probe(struct platform_device *pdev)
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> - priv->clk = devm_clk_get(dev, NULL);
> + priv->clk = devm_clk_get_enabled(dev, NULL);
This is just confusing or even wrong. You do not understand the code,
just blindly do some changes pointed by scripting.
NAK.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-24 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 3:23 [PATCH] nvmem: imx-ocotp: Use helper function devm_clk_get_enabled() Huan Tang
2025-06-24 6:50 ` Krzysztof Kozlowski [this message]
2025-06-24 6:52 ` Krzysztof Kozlowski
2025-06-24 8:33 ` Huan Tang
2025-06-24 8:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00e76ce2-126a-40ab-badd-210a20041843@kernel.org \
--to=krzk@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srini@kernel.org \
--cc=tanghuan@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox