From mboxrd@z Thu Jan  1 00:00:00 1970
From: kgene.kim@samsung.com (Kukjin Kim)
Date: Tue, 03 Aug 2010 14:07:18 +0900
Subject: [PATCH 1/3] ARM: S5PC110/S5PC210: Add the C Preprocessor
	directives for gpio.h
In-Reply-To: <20100802002457.GA32257@july>
References: <20100802002457.GA32257@july>
Message-ID: <00f001cb32c9$c21eba00$465c2e00$%kim@samsung.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Make a buile error when include the mach/gpio.h directly.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-s5pv210/include/mach/gpio.h |    4 ++++
>  arch/arm/mach-s5pv310/include/mach/gpio.h |    4 ++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/include/mach/gpio.h b/arch/arm/mach-
> s5pv210/include/mach/gpio.h
> index 1f4b595..7798693 100644
> --- a/arch/arm/mach-s5pv210/include/mach/gpio.h
> +++ b/arch/arm/mach-s5pv210/include/mach/gpio.h
> @@ -13,6 +13,10 @@
>  #ifndef __ASM_ARCH_GPIO_H
>  #define __ASM_ARCH_GPIO_H __FILE__
> 
> +#ifndef __LINUX_GPIO_H
> +#error "Don't include the mach/gpio.h directly. use the linux/gpio.h"
> +#endif
> +
>  #define gpio_get_value	__gpio_get_value
>  #define gpio_set_value	__gpio_set_value
>  #define gpio_cansleep	__gpio_cansleep
> diff --git a/arch/arm/mach-s5pv310/include/mach/gpio.h b/arch/arm/mach-
> s5pv310/include/mach/gpio.h
> index 20cb80c..3f751f2 100644
> --- a/arch/arm/mach-s5pv310/include/mach/gpio.h
> +++ b/arch/arm/mach-s5pv310/include/mach/gpio.h
> @@ -13,6 +13,10 @@
>  #ifndef __ASM_ARCH_GPIO_H
>  #define __ASM_ARCH_GPIO_H __FILE__
> 
> +#ifndef __LINUX_GPIO_H
> +#error "Don't include the mach/gpio.h directly. use the linux/gpio.h"
> +#endif
> +
>  #define gpio_get_value	__gpio_get_value
>  #define gpio_set_value	__gpio_set_value
>  #define gpio_cansleep	__gpio_cansleep
> --

Again, Cc'ed Ben Dooks...Please add him in Cc...

_ARCH_ARM_GPIO_H is better...if defined it, it means including
mach/gpio.h...

Anyway...but I think we no need above warning message...because I will check
it before merging in my tree...
And if required, I will fix all of samsung stuff about inclusion
mach/gpio.h...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.