From: yitian.bu@tangramtek.com (yitian)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method
Date: Thu, 1 Oct 2015 10:39:09 +0800 [thread overview]
Message-ID: <00fe01d0fbf2$5a73cba0$0f5b62e0$@tangramtek.com> (raw)
In-Reply-To: <20150930181751.GT15635@sirena.org.uk>
> From: linux-arm-kernel
> [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of Mark
> Brown
> Sent: Thursday, October 1, 2015 2:18 AM
> To: yitian <yitian.bu@tangramtek.com>
> Cc: alsa-devel at alsa-project.org; wsa at the-dreams.de;
> linux-kernel at vger.kernel.org; Andrew.Jackson at arm.com; tiwai at suse.com;
> lgirdwood at gmail.com; perex at perex.cz;
> linux-arm-kernel at lists.infradead.org
> Subject: Re: [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method
>
> On Tue, Sep 29, 2015 at 10:39:00PM +0800, yitian wrote:
> > from Designware I2S datasheet, irq is cleared by reading from
> > TOR/ROR registers, rather than by writing into them.
>
> This doesn't apply against current code, please check and resend.
Hi Mark:
Thanks for your comments.
Maybe I misunderstand your meaning. Please correct me.
I synced up to latest kernel branch, the code is the same as what this patch
was
generated.
I checked designware I2S spec "version 1.08a June 2014", it specified that
the TOR
and ROR registers are read only and reading the last bit will clear tx/rx
overrun irq.
Also I have checked this register by writing its last bit, the overrun irq
is not cleared.
But if I read the last bit, the overrun irq is cleared. That means the spec
is correct.
Can you please let me know what else I should double check? Thanks.
next prev parent reply other threads:[~2015-10-01 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 14:39 [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method yitian
2015-09-30 18:17 ` Mark Brown
2015-10-01 2:39 ` yitian [this message]
2015-10-01 10:03 ` Mark Brown
2015-10-02 7:22 ` [alsa-devel] " yitian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fe01d0fbf2$5a73cba0$0f5b62e0$@tangramtek.com' \
--to=yitian.bu@tangramtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).