[PATCH] ARM: S3C24XX: Fix build error for missing <mach/system-reset.h>

[PATCH] ARM: S3C24XX: Fix build error for missing <mach/system-reset.h>

[Kukjin Kim]

Since the arch/arm/mach-s3c2410/include/mach/system-reset.h has
been removed by commit f88b8979 ("ARM: restart: remove the now
empty arch_reset()"), so the inclusion of <mach/system-reset.h>
should be removed at the plat-s3c24xx/cpu.c file.

The build error happens like following:
  arch/arm/plat-s3c24xx/cpu.c:41: fatal error: mach/system-reset.h: No such file or directory

Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
Russell,

I think, you missed removing this in your patch.
If you have patches to send to Linus for this merge window,
could you please send this together? Or...?

 arch/arm/plat-s3c24xx/cpu.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-s3c24xx/cpu.c b/arch/arm/plat-s3c24xx/cpu.c
index 1121df1..21f1fda 100644
--- a/arch/arm/plat-s3c24xx/cpu.c
+++ b/arch/arm/plat-s3c24xx/cpu.c
@@ -38,8 +38,6 @@
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
-#include <mach/system-reset.h>
-
 #include <mach/regs-gpio.h>
 #include <plat/regs-serial.h>
 
-- 
1.7.1

[PATCH] ARM: S3C24XX: Fix build error for missing <mach/system-reset.h>

[Russell King - ARM Linux]

On Sat, Jan 07, 2012 at 08:47:47PM +0900, Kukjin Kim wrote:
> Since the arch/arm/mach-s3c2410/include/mach/system-reset.h has
> been removed by commit f88b8979 ("ARM: restart: remove the now
> empty arch_reset()"), so the inclusion of <mach/system-reset.h>
> should be removed at the plat-s3c24xx/cpu.c file.
> 
> The build error happens like following:
>   arch/arm/plat-s3c24xx/cpu.c:41: fatal error: mach/system-reset.h: No such file or directory
> 
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> Russell,
> 
> I think, you missed removing this in your patch.

This rather proves the point that the way Samsung stuff is organized is
just too complicated to be properly understood.  Yes, it's getting better
as a result of some of the points I raised, but I feel its still too
opaque for anyone except those who know it intimiately to get to grips
with it properly, and follow how the code is organized through all those
plat-* and mach-* directories.

> If you have patches to send to Linus for this merge window,
> could you please send this together? Or...?

Please put it in the patch system and I'll queue it up.  Thanks.

[PATCH] ARM: S3C24XX: Fix build error for missing <mach/system-reset.h>

[Kukjin Kim]

Russell King - ARM Linux wrote:
> 
> On Sat, Jan 07, 2012 at 08:47:47PM +0900, Kukjin Kim wrote:
> > Since the arch/arm/mach-s3c2410/include/mach/system-reset.h has
> > been removed by commit f88b8979 ("ARM: restart: remove the now
> > empty arch_reset()"), so the inclusion of <mach/system-reset.h>
> > should be removed at the plat-s3c24xx/cpu.c file.
> >
> > The build error happens like following:
> >   arch/arm/plat-s3c24xx/cpu.c:41: fatal error: mach/system-reset.h: No
> such file or directory
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > Russell,
> >
> > I think, you missed removing this in your patch.
> 
> This rather proves the point that the way Samsung stuff is organized is
> just too complicated to be properly understood.  Yes, it's getting better

Yes, I agree ;) and in my opinion, it was hard to merge samsung stuff for
this merge window because some changes are in arm tree and some in arm-soc
tree. In addition, driver-core tree. Anyway, I had to do earlier both :)

> as a result of some of the points I raised, but I feel its still too
> opaque for anyone except those who know it intimiately to get to grips
> with it properly, and follow how the code is organized through all those
> plat-* and mach-* directories.
> 
> > If you have patches to send to Linus for this merge window,
> > could you please send this together? Or...?
> 
> Please put it in the patch system and I'll queue it up.  Thanks.

OK, I did just now.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.