From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Sat, 07 Jan 2012 21:23:48 +0900 Subject: [PATCH] ARM: S3C24XX: Fix build error for missing In-Reply-To: <20120107115914.GE13857@n2100.arm.linux.org.uk> References: <010101cccd32$2cf0cfe0$86d26fa0$%kim@samsung.com> <20120107115914.GE13857@n2100.arm.linux.org.uk> Message-ID: <010c01cccd37$357ea790$a07bf6b0$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Russell King - ARM Linux wrote: > > On Sat, Jan 07, 2012 at 08:47:47PM +0900, Kukjin Kim wrote: > > Since the arch/arm/mach-s3c2410/include/mach/system-reset.h has > > been removed by commit f88b8979 ("ARM: restart: remove the now > > empty arch_reset()"), so the inclusion of > > should be removed at the plat-s3c24xx/cpu.c file. > > > > The build error happens like following: > > arch/arm/plat-s3c24xx/cpu.c:41: fatal error: mach/system-reset.h: No > such file or directory > > > > Signed-off-by: Kukjin Kim > > --- > > Russell, > > > > I think, you missed removing this in your patch. > > This rather proves the point that the way Samsung stuff is organized is > just too complicated to be properly understood. Yes, it's getting better Yes, I agree ;) and in my opinion, it was hard to merge samsung stuff for this merge window because some changes are in arm tree and some in arm-soc tree. In addition, driver-core tree. Anyway, I had to do earlier both :) > as a result of some of the points I raised, but I feel its still too > opaque for anyone except those who know it intimiately to get to grips > with it properly, and follow how the code is organized through all those > plat-* and mach-* directories. > > > If you have patches to send to Linus for this merge window, > > could you please send this together? Or...? > > Please put it in the patch system and I'll queue it up. Thanks. OK, I did just now. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.