From mboxrd@z Thu Jan  1 00:00:00 1970
From: kgene.kim@samsung.com (Kukjin Kim)
Date: Thu, 09 Sep 2010 20:18:10 +0900
Subject: [PATCH 2/2] ARM: S3C64XX: Prototype SPI devices
In-Reply-To: <20100908124605.GA10413@rakim.wolfsonmicro.main>
References: <1283941539-3892-1-git-send-email-broonie@opensource.wolfsonmicro.com>
	<1283941539-3892-2-git-send-email-broonie@opensource.wolfsonmicro.com>
	<004201cb4f52$df6e6e20$9e4b4a60$%kim@samsung.com>
	<20100908124605.GA10413@rakim.wolfsonmicro.main>
Message-ID: <011001cb5010$b2848840$178d98c0$%kim@samsung.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Mark Brown wrote:
> 
> On Wed, Sep 08, 2010 at 09:39:21PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> 
> > > Avoids build warnings due to the undeclared non-statics.
> 
> > Could you please let me know what's the build warning?
> 
> It'll have been something along the lines of:
> 
> 's3c64xx_device_iis0' not declared; should it be static?
> 

> for each device.  Possibly generated by sparse rather than GCC - I
> always build with sparse as well.

Hi Mark,

Sorry...I can't understand your comment.

You mean the build warning is 's3c64xx_device_iis0' is not declared..right?
Hmm...the 's3c64xx_device_iis0' used only in a mach-s3c64xx/mach-smartq.c
file.
And defined it as extern struct in a plat-samsung/include/plat/devs.h file.
...So...why need to modify mach-s3c64xx/dev-spi.c for it?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.