From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Darren.Ye" <darren.ye@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add support for MT8196 audio AFE controller
Date: Sun, 22 Jun 2025 11:43:11 +0200 [thread overview]
Message-ID: <011093f8-85a1-4c3c-b3fa-7be9e6df8a25@kernel.org> (raw)
In-Reply-To: <20250620094140.11093-9-darren.ye@mediatek.com>
On 20/06/2025 11:40, Darren.Ye wrote:
> From: Darren Ye <darren.ye@mediatek.com>
>
> This patch adds initial support for the audio AFE(Audio Front End) controller
Why this was changed to undesired 'This patch' (see submitting patches)?
I think you are circling back to previous versions, reintroducing issues
fixed in between.
> on the mediatek MT8196 platform.
>
> Signed-off-by: Darren Ye <darren.ye@mediatek.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: I asked to drop document, because the rest was correct and you
totally rewritten it to unnecessary too long subject.
Well, at least the rest you implemented, but I just don't get why, when
asked to change something you change several things to less desired style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-22 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 9:40 [PATCH v5 00/10] ASoC: mediatek: Add support for MT8196 SoC Darren.Ye
2025-06-20 9:40 ` [PATCH v5 01/10] ASoC: mediatek: common: modify mtk afe platform driver for mt8196 Darren.Ye
2025-06-21 8:34 ` kernel test robot
2025-06-20 9:40 ` [PATCH v5 03/10] ASoC: mediatek: mt8196: support audio clock control Darren.Ye
2025-06-20 9:40 ` [PATCH v5 04/10] ASoC: mediatek: mt8196: support ADDA in platform driver Darren.Ye
2025-06-20 9:40 ` [PATCH v5 06/10] ASoC: mediatek: mt8196: support TDM " Darren.Ye
2025-06-20 9:40 ` [PATCH v5 07/10] ASoC: mediatek: mt8196: add " Darren.Ye
2025-06-23 9:29 ` AngeloGioacchino Del Regno
2025-06-20 9:40 ` [PATCH v5 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add support for MT8196 audio AFE controller Darren.Ye
2025-06-22 9:43 ` Krzysztof Kozlowski [this message]
2025-06-23 6:52 ` Darren Ye (叶飞)
2025-06-23 7:30 ` Krzysztof Kozlowski
2025-06-20 9:40 ` [PATCH v5 09/10] ASoC: mediatek: mt8196: add machine driver with nau8825 Darren.Ye
2025-06-20 9:40 ` [PATCH v5 10/10] ASoC: dt-bindings: mediatek,mt8196-nau8825: Add audio sound card Darren.Ye
2025-06-22 11:25 ` Krzysztof Kozlowski
[not found] ` <20250620094140.11093-6-darren.ye@mediatek.com>
2025-06-23 9:05 ` [PATCH v5 05/10] ASoC: mediatek: mt8196: support I2S in platform driver AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011093f8-85a1-4c3c-b3fa-7be9e6df8a25@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=darren.ye@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).