From: sangsu4u.park@samsung.com (Sangsu Park)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND][PATCH] ARM: EXYNOS: Add clocks for EXYNOS I2S and PCM I/F
Date: Fri, 08 Feb 2013 17:57:08 +0900 [thread overview]
Message-ID: <011101ce05da$46be7760$d43b6620$@samsung.com> (raw)
In-Reply-To: <CAAgF-Be1UKyyX0VBkdy7GbhxH4mZmsVwskr2Yj3TM54qjs6dEQ@mail.gmail.com>
On Fri, Feb 8, 2013 at 13:23 PM, Padma Venkat <padma.kvr@gmail.com> wrote:
> On Wed, Feb 6, 2013 at 10:51 AM, Sangsu Park <sangsu4u.park@samsung.com>
wrote:
> > +void __init exynos_register_audss_clocks(void)
> > +{
> > + clk_audss_base = ioremap(EXYNOS_PA_AUDSS, SZ_4K);
> > + if (clk_audss_base == NULL) {
>
> Please run checkpatch. There should be space after if.
I mistakenly forgot checking patch with checkpatch.
I can find some errors and warnings about this patch.
I'll fix them. Thank you for your comment.
>
> > + pr_err("unable to ioremap for gpio_base1\n");
>
> Please fix the err message.
I'll change it. :)
Thanks.
Sangsu Park
prev parent reply other threads:[~2013-02-08 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 5:21 [RESEND][PATCH] ARM: EXYNOS: Add clocks for EXYNOS I2S and PCM I/F Sangsu Park
2013-02-06 5:29 ` Sachin Kamat
2013-02-06 5:42 ` Sangsu Park
2013-02-08 4:22 ` Padma Venkat
2013-02-08 8:57 ` Sangsu Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011101ce05da$46be7760$d43b6620$@samsung.com' \
--to=sangsu4u.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox