From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96294C27C5E for ; Tue, 11 Jun 2024 06:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9NStJbY9sfM/caes+diUPeqxtoeZ1qOQt/clZmag2DM=; b=IlcvRdoNiEuCD8 4ehXSWLeuEkIblm+lxLMS2GUQ0drX47A/sIYMmWI6ycgaT9CeBrYkohnWzuC+QN91BaXESczaQviZ 6Vcb0aymnEF1JEZUZnBNLvYFdTz8hZgj8VyJOjmxBlqCs0ao20oN1u73ZEYIjuLzHrnjzEg8mM6ba faahapYgQ9262hVTWCY48dIbLVE22axDoY3JoIf53W86OIVlY1vY9P1ePsUTqdjT+SSOzRRQVfjq8 INyJy8Jj8zS2IPDOmd/zQY3Rrwpf8zrZrvU0FYJPfm5kuwG4UmNQlEnJibgTBAe1PyBC2eGg5KC1N PP2Mtut2lNQv/hrvXh3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGucc-00000007clM-0xys; Tue, 11 Jun 2024 06:04:42 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGucX-00000007cks-3J0d for linux-arm-kernel@lists.infradead.org; Tue, 11 Jun 2024 06:04:39 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-52c815e8e9eso2662673e87.0 for ; Mon, 10 Jun 2024 23:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718085872; x=1718690672; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yAPZO3yTkrqMJ5pPtOySZTxQ0ESxWcduJjtdKssr1x0=; b=AV1hddcMFDU6D0a3Kl6+79PRpkMuKZ4MmTCLMET/93bSIkQT6/z1sGw1OXZBQqv99O lg64uW8OGaKjKt/B539zJMX8HDLeGaIrkbQbe1SLRjaUPLGdCze9QGgXH1KFixDuoja6 mO/So6A4q3BfxN01y/7qj/+Qh/fp5yH5SROG4r02AUj4rDaXUs7cSmQRxn2OLZvmCMD8 TxZeZuHHwlTz6TsIlvTZWbuN0ym9++chZp3z7DN957DpcaxxuLZfgnWt5W2pdQLCbere DVzfF/RlV1o3msplkeBl6QFwN+sEYMhQp2j4MmNshPvaMbdBWRjgilZwIJBNj4etULU5 /qiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718085872; x=1718690672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yAPZO3yTkrqMJ5pPtOySZTxQ0ESxWcduJjtdKssr1x0=; b=uKB7g9AWu1Ape9N14/vnUwSQQhF3DMwa9VB/ObfEt8V+TIpZKIlEnCnC7YMTb8VPgp Oz2+LL9L54yyJVRipyK5xYm1Gd9b7xN38TluP1RvBfPjJmA/zvfgNOIH/UzQHp90Zz+x a9l/BON52vKCtNttxiTnLIrlo5P+HRUG4PrBVfLNS7O9JXtrsm3obxYhNUkDbcHnblP0 mO4tcnaLGHjgAbzqKRTxJ/NIKc+yv5Pnc7HeqJy/OpzVSAuw1CvJsZ7LgQnVgljCQQf1 xvrVuk56eFlDNrrkPnHPOeIsgjSFb4LH7a0pe0slt76gV5vvnlrpEhTHHz+npGika8x+ e3Ig== X-Forwarded-Encrypted: i=1; AJvYcCXpE85SDzBkL7O1xW3RNeOkqIBIoEb+WJ0MnXtAKyWtFYXLi8GtAv+HJ6Wy2G3ahQ6dpMkLqu1sLar8968D4+kDpiu+EYGhj/tjPflwT9s+OJPlOtg= X-Gm-Message-State: AOJu0YwYgKX4HP1vZNPmvuDj2pcxYOjmBJYDsHSt6/JdyJCA3NYSLLbQ c6Z7HDYsCwOHzx+WiKyUA7nyVACFley76OHo6lEm4DJ5n1qbAQ39+0a1at67Z88= X-Google-Smtp-Source: AGHT+IGnLjRuH5I3DZyMOkcQJRaqyoOS3zZjJWaQBS2WlZZraSJ2sjozH7QJS+RDPy719gYBD4WbhQ== X-Received: by 2002:a05:6512:3f10:b0:52b:59f7:7602 with SMTP id 2adb3069b0e04-52bb9f66381mr9382633e87.8.1718085872022; Mon, 10 Jun 2024 23:04:32 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f25dc3f07sm3798947f8f.79.2024.06.10.23.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 23:04:31 -0700 (PDT) Date: Tue, 11 Jun 2024 09:04:28 +0300 From: Dan Carpenter To: Stefan Wahren , Laurent Pinchart Cc: Greg Kroah-Hartman , Florian Fainelli , Umang Jain , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 07/10] staging: vchiq_arm: Reduce indentation of service_callback Message-ID: <01190bf2-c698-423a-b587-c80ce5d92bb8@moroto.mountain> References: <20240610210220.95524-1-wahrenst@gmx.net> <20240610210220.95524-8-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240610210220.95524-8-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_230437_990638_AF08A610 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 10, 2024 at 11:02:17PM +0200, Stefan Wahren wrote: > The service_callback has 5 levels of indentation, which makes it > hard to read. Reduce this by splitting the code in a new function > service_single_message() as suggested by Laurent Pinchart. > > Signed-off-by: Stefan Wahren To be honest, I liked the version of this patch which Laurent didn't like. Even after pulling this code into a separate function, I'd still support flipping the conditions around and adding the goto... Laurent, you really didn't like the goto? regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel