From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F17C5C433EF for ; Wed, 29 Jun 2022 00:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bc3zbVPppV5aUVk0WtAYbyvhXXgtBChkrRvr5/kM6YE=; b=i14Qa2x0fbQk9z oyW3EX1HdLsCh65gTxvB4b+GjS4tF3yf0CSokUDFcGOExoHHBrIBTXMzo68jRfv2BjrpHgwZmI/jd 7nHE6NptnL1xU1GVsQDm06iId6FHmBgZIVlicMcsR6nkUO+HdTfI9jOgMI9hV+jbV6XimQc35vQLA oAUlegHRFMJNU8iI1iQs/zT2FESAI9a8IuDbqXdy2s7CR6YM4nceer4bHwqZ/nmwtXBF0jyTz1qHG IE5nbxqXsMdvC/pDsgjnBhleSxhtibdfdooYtB0cIIEc9UOGS86oP59SuE7aUNMaVJfA4GcQHMKO8 Jqiue+akWC1v7q+Vr+Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6LbM-008lEW-5V; Wed, 29 Jun 2022 00:30:40 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6LbE-008lCb-LN for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 00:30:38 +0000 Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220629003002epoutp03a606d4f4057c9d18e3634dbced6735ee~87-X2lP8t2296822968epoutp03O for ; Wed, 29 Jun 2022 00:30:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220629003002epoutp03a606d4f4057c9d18e3634dbced6735ee~87-X2lP8t2296822968epoutp03O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1656462602; bh=RCT9O8q2k+aVrdvpyyII4wNB8PekhyTijb9GQ6sFNeg=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=bXckLCDGF2cbC7al17jtlciUpdiDsaZ6NzGRe23c6NdIQJYy255VQgS8P3qTQqMCa K35ZYdQbKZz7qjEyTrsJwSr3U/pk00Hm+uqmI8LomU+3lbAWnzEL5EmAFzNar0h9TA h4dvvzYWROp0z7uEkuE8Ljcf5+KbgZGuojibImHQ= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20220629003001epcas2p1fac056d425b366f2369b28a45957bf5b~87-W_ncnV0474004740epcas2p1f; Wed, 29 Jun 2022 00:30:01 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.89]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LXj610k2Sz4x9Q0; Wed, 29 Jun 2022 00:30:01 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id EB.64.09642.80D9BB26; Wed, 29 Jun 2022 09:30:00 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20220629003000epcas2p1285b1a7d7fe74efdae6bae9c8886007b~87-Vx4Xwm0473304733epcas2p1Z; Wed, 29 Jun 2022 00:30:00 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220629003000epsmtrp129d2ef67a582b7a9517e5d463a65b09d~87-Vw0PVT0743907439epsmtrp1R; Wed, 29 Jun 2022 00:30:00 +0000 (GMT) X-AuditID: b6c32a47-5f7ff700000025aa-95-62bb9d08b8a3 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 38.4C.08905.80D9BB26; Wed, 29 Jun 2022 09:30:00 +0900 (KST) Received: from KORCO082417 (unknown [10.229.8.121]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220629003000epsmtip283526fcc161ba0ec44364975c7e9d7f6~87-Vlkvcw0746407464epsmtip2g; Wed, 29 Jun 2022 00:30:00 +0000 (GMT) From: "Chanho Park" To: =?iso-8859-1?Q?'Ilpo_J=E4rvinen'?= Cc: "'Krzysztof Kozlowski'" , "'Greg Kroah-Hartman'" , "'Jiri Slaby'" , "'Alim Akhtar'" , "'Hector Martin'" , "'Jaewon Kim'" , "'Vincent Whitchurch'" , , "'linux-serial'" , In-Reply-To: Subject: RE: [PATCH v2] tty: serial: samsung_tty: loopback mode support Date: Wed, 29 Jun 2022 09:29:59 +0900 Message-ID: <012401d88b4f$5ddd2180$19976480$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: ko Thread-Index: AQLQReUt4gszEHpOmY4yS3t4neww3AL4ITK4Ah5+OAmrTV0CUA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHJsWRmVeSWpSXmKPExsWy7bCmuS7H3N1JBvt7rC0ezNvGZtG8eD2b ReeOHhaLHQ1HWC3ezZWx2Pt6K7vFpsfXWC1mnN/HZHFmcS+7xelrC9gtzm/zd+D2uL4uwGPT qk42jzvX9rB5zDsZ6LF/7hp2j81L6j0WL9vJ5tG3ZRWjx+dNcgGcUdk2GamJKalFCql5yfkp mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUCXKimUJeaUAoUCEouLlfTtbIry S0tSFTLyi0tslVILUnIKzAv0ihNzi0vz0vXyUkusDA0MjEyBChOyM/Zs+MVccIar4sGla0wN jMc4uxg5OSQETCTaP21h62Lk4hAS2MEo8fLlMlYI5xOjxOSrt6Ey3xgldq76wgTT8mHlF6jE XkaJmxues0M4Lxglbj27zg5SxSagL/GyYxsriC0i4CbRt+MZC0gRs8AVZomTm06zgSQ4BZwl vix/zQhiCwu4S9w48gesgUVAVWL3g0csIDavgKVEw8IGJghbUOLkzCdgcWYBPYkbU6ewQdja EssWvmaGOE9B4ufTZawQcRGJ2Z1tzBBHOElM+70a7GwJgSMcEisvTGWDaHCROHFzGyOELSzx 6vgWdghbSuJlfxuUXSyxdNYnJojmBkaJy9t+QTUbS8x61g7UzAFkK0scuQV1HJ9Ex+G/7BBh XomONiGIanWJA9uns0DYshLdcz6zTmBUmoXktVlIXpuF5LVZSN5ZwMiyilEstaA4Nz212KjA GB7hyfm5mxjBCVnLfQfjjLcf9A4xMnEwHmKU4GBWEuFdeGZnkhBvSmJlVWpRfnxRaU5q8SFG U2BoT2SWEk3OB+aEvJJ4QxNLAxMzM0NzI1MDcyVxXq+UDYlCAumJJanZqakFqUUwfUwcnFIN TKtutqtJ1qovYVrQ9uJoomDMG8fkJff/R8w+ULHk/ewZuyyDrM28X2vfnlk779yEkvXJ87jY mBPaJrbm+a5sdfeV+OQtzfYi92urQOgMc/9vTLuqcpaVTfT6b1oYfE19tcGG6wqWnN1b5rBY PlT5cbKufffMwIRon/n6+YtvOmx46Bt2Ttanimk5u3YR97XjK6YseSBce4vrl3qpoOXP3TXz WB5ZSeTw/pXbpZwXNafab9s6poeTPbaJSKrPC/Xf4WdySDxX6fOj5anOYsd4n9S/umJW/G/u lsQCmW9OIvcq97WezvpzL/rNp322T+e/eVXy9+6aW/Fxh6WS1/qY3XpYvbqE6Wdr2qvLR5Yc 6lBiKc5INNRiLipOBAA0SyxWUQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsWy7bCSvC7H3N1JBr8miVo8mLeNzaJ58Xo2 i84dPSwWOxqOsFq8mytjsff1VnaLTY+vsVrMOL+PyeLM4l52i9PXFrBbnN/m78DtcX1dgMem VZ1sHneu7WHzmHcy0GP/3DXsHpuX1HssXraTzaNvyypGj8+b5AI4o7hsUlJzMstSi/TtErgy Ti6+zFxwiqNixu1PzA2M99m6GDk5JARMJD6s/AJkc3EICexmlNi0YB5UQlbi2bsd7BC2sMT9 liOsEEXPGCXuHv3BCJJgE9CXeNmxjRXEFhFwk+jb8YwFpIhZ4BazRMf+DVAdJxglljbfBOvg FHCW+LL8NZgtLOAucePIH7BuFgFVid0PHrGA2LwClhINCxuYIGxBiZMzn4DFmQUMJO4f6mCF sLUlli18zQxxnoLEz6fLoOIiErM725ghLnKSmPZ7NdsERuFZSEbNQjJqFpJRs5C0L2BkWcUo mVpQnJueW2xYYJiXWq5XnJhbXJqXrpecn7uJERyZWpo7GLev+qB3iJGJg/EQowQHs5II78Iz O5OEeFMSK6tSi/Lji0pzUosPMUpzsCiJ817oOhkvJJCeWJKanZpakFoEk2Xi4JRqYDqi8Fv9 XMFL/vzDEfVTmp6tLMkMnNfjeOVO/CWlA8ssKsutT/74PJfHwLYxbscBwd++InVB/C18ps8+ 7ml/dPtXR37f29U7TVrbd6s7b2qTN2N2/KZ64OPiSRGcM81ydC2e7tri2caQf8XOt2DrzPea VgJ7DgqnKz0I4GNcFxIs8u9a0MowRl6z46d1+udpvrOJ6Nwn0vewMF3W/5TSEbkDavdke9bs OLzq4J8+Xder+o8XnZBtuB4e/1ultH1iWv9b17wtP/yjQ606pJa9f+nwW5I//fRSjaiP0tu1 CnQPv62pzqt6wCZw5IlT63PzS9tOH2FRfzPtQ1rG3ma27B9bFsVb1DafXbJa3eOAtBJLcUai oRZzUXEiADvx1oM7AwAA X-CMS-MailID: 20220629003000epcas2p1285b1a7d7fe74efdae6bae9c8886007b X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220628124300epcas2p45f1e3a7051bb93ecba778cf7d96720d3 References: <20220628124050.144398-1-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_173035_047217_6E2966A9 X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Internal loopback mode can be supported by setting UCON register's > > Loopback Mode bit. The mode & bit can be supported since > > s3c2410 and later SoCs. The prefix of LOOPBACK / BIT(5) naming should > > be also changed to S3C2410_ to avoid confusion. > > > > We can test it by linux-serial-test program with -k option. The tool > > will set TIOCM_LOOP mode when the option is specified. > > -k, --loopback Use internal hardware loop back > > > > Signed-off-by: Chanho Park > = > Reviewed-by: Ilpo J=E4rvinen Thanks for your review. > = > You should have included Krzysztof's Reviewed-by when you sent this next > version so that it won't get lost. I thought the codes have been changed since v1 so I'm not convinced I can put his R-B tag. > = > I suspect Greg will again complain that you didn't address his comment > about the out of the place "-k, --loopback ..." line. The commit messages seems to be not necessary. I'll remove them next patch. Best Regards, Chanho Park _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel