From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F341AC2D0A3 for ; Tue, 27 Oct 2020 00:24:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A93D920759 for ; Tue, 27 Oct 2020 00:24:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iV3sy3Nx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="DV6OWsJ8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A93D920759 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X2FDp5qu1J8DtFtb9kjo5BWigJ2LDvB4JjEuCVdnsqw=; b=iV3sy3NxGgBAyEC9nAsIKNDqx hzliJak8DQD76CGNDRQlK1FLurXGuzeQdKVqezYGtFC7iREJiSd2y8oKIBpNY55iV0vWOoryMCRmK dpLZdKolEcIDRhQG4A0VikIvpCZiKse1CKCGWvbbYwJgvE+Af4ksPDhkk0AUB8kwYlIN6BODHcskr gVxdEhUK8tIgFn4wC4AHD0mWRa/bMBKbl/WC39mXLiSWygjuUFpZJ3/Hukm/2Te89DMRBa3tofiP1 2BAfV6t46VWhh4AIAo7zGk1LObpZEfRobzU9MODNpz09FCU3QjEkBCegeDrUxkVQ+oslpEpQZFLqk J0IhicoSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXCkI-0007A6-Rk; Tue, 27 Oct 2020 00:21:50 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXCY3-0001fZ-IR for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 00:09:35 +0000 Received: by mail-pg1-x543.google.com with SMTP id z24so941274pgk.3 for ; Mon, 26 Oct 2020 17:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LsJlRjdqhDVAHhw47g/atIos95r5K18qubNura+3fzc=; b=DV6OWsJ8YTis4RWe74HnMoSPHx2wnbbnih3F0P+HiF57IXnyKrAIcBplDa0TuQW0fe aii8O67y5CuNtSNcN0q+CPIFocqT+ma+us4RoqX4TC6tMgaGBGUnwVHQJ/N6qPZoUIZl N8PZQaTFtDJvhHp2KmiMn99XHribiQTVBqggOOByg6ZsC+AIdPeSZ7IIhzJWtbXj8peQ vUIkbSwJfbOC01KBcysHUuhejsj0lkLWHowENLgMtxCKJmsxzr5jKuNTtJsywdn514eT kI7wIhvyoH92wMz2QHWzCBEBrmMggfxor976qEm1YW1xHPKbqwPNkX7lWR3OAQC8rWrk OKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LsJlRjdqhDVAHhw47g/atIos95r5K18qubNura+3fzc=; b=G9BLrQ1zsuCMyJHVP0rMFLFv+w7fB0bglt+Pb0oc1Qxd8bX7KmimUJ9sGXI6tRcr/n 9udhMP6yN0TrU7cB5uwlp6lr3E+7/1tnR4Vpon+S9W26G3jEBpHl5babok/imhqlHD/G SZctajcqHtFMTGqDvGvLC+QpHss9PFC7Vk8nEcFHlyGMMdMsN+kucYtiy9TvBjCk7Lco bi9gqWATw+CuYfG3mK7wXhQNjWY8kqNMps3ditunkzLrMTIHGpnbkJcJMfWjp4C3SfIt 246b0Ga1auRWaHJZUzQ/lE7DbiiJ5XGzyHOJQZ8LqzzpD1VDEoYe5+sMVrBlKQE+xknm mX0Q== X-Gm-Message-State: AOAM533+b4rLl4lFLsP35V0b22q7AM4maJhfiaGSsHwS/CzOPB8NdPSB Xf2G9aabnMDWi/OfNqKeYbK83Q== X-Google-Smtp-Source: ABdhPJzyk1CokDb3PmPO6AYN5WbyxmkTO2goVocCEnl70vwlgJZot7evNIwwh9o3S+Q92QVwXSE2HA== X-Received: by 2002:a65:5c02:: with SMTP id u2mr18125891pgr.173.1603757348944; Mon, 26 Oct 2020 17:09:08 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id e16sm13676837pfh.45.2020.10.26.17.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 17:09:08 -0700 (PDT) Subject: Re: [REGRESSION] mm: process_vm_readv testcase no longer works after compat_prcoess_vm_readv removed To: Al Viro References: <70d5569e-4ad6-988a-e047-5d12d298684c@kernel.dk> <20201027000521.GD3576660@ZenIV.linux.org.uk> From: Jens Axboe Message-ID: <0127a542-3f93-7bd0-e00d-4a0e49846c8f@kernel.dk> Date: Mon, 26 Oct 2020 18:09:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027000521.GD3576660@ZenIV.linux.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_200911_902562_CA9A1EFC X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aio@kvack.org, linux-mips@vger.kernel.org, David Howells , linux-mm@kvack.org, keyrings@vger.kernel.org, sparclinux@vger.kernel.org, Christoph Hellwig , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , linux-security-module@vger.kernel.org, Robert O'Callahan , Linus Torvalds , Arnd Bergmann , linux-block@vger.kernel.org, io-uring@vger.kernel.org, "moderated list:ARM PORT" , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, open list , Kyle Huey , "open list:FILESYSTEMS \(VFS and infrastructure\)" , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/26/20 6:05 PM, Al Viro wrote: > On Mon, Oct 26, 2020 at 05:56:11PM -0600, Jens Axboe wrote: >> On 10/26/20 4:55 PM, Kyle Huey wrote: >>> A test program from the rr[0] test suite, vm_readv_writev[1], no >>> longer works on 5.10-rc1 when compiled as a 32 bit binary and executed >>> on a 64 bit kernel. The first process_vm_readv call (on line 35) now >>> fails with EFAULT. I have bisected this to >>> c3973b401ef2b0b8005f8074a10e96e3ea093823. >>> >>> It should be fairly straightforward to extract the test case from our >>> repository into a standalone program. >> >> Can you check with this applied? >> >> diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c >> index fd12da80b6f2..05676722d9cd 100644 >> --- a/mm/process_vm_access.c >> +++ b/mm/process_vm_access.c >> @@ -273,7 +273,8 @@ static ssize_t process_vm_rw(pid_t pid, >> return rc; >> if (!iov_iter_count(&iter)) >> goto free_iov_l; >> - iov_r = iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r, false); >> + iov_r = iovec_from_user(rvec, riovcnt, UIO_FASTIOV, iovstack_r, >> + in_compat_syscall()); > > _ouch_ > > There's a bug, all right, but I'm not sure that this is all there is > to it. For now it's probably the right fix, but... Consider the fun > trying to use that from 32bit process to access the memory of 64bit > one. IOW, we might want to add an explicit flag for "force 64bit > addresses/sizes in rvec". Ouch yes good point, nice catch. -- Jens Axboe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel