From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A93DBC7EE23 for ; Tue, 23 May 2023 09:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JjPwIBNhbvUKrugPI75EuPwQ0vpuTnDD0fX2RxY8DfM=; b=nskE/qiMbMThBh Wk3Xd0wuGGN6b8aRe9XrdqaiiMyZJQBh99g0MUKZE8iwnM6vSayPJKECJ45R2ygnrea/DznNh03R2 wNyAvquCvaFq2dzbyrfNe+URpGZ2oy4NHOKdD64HRSfZqhqX8nhqtIFYEGouO7uGH4uhPikY/abJW Dh0nJri/YmQyLCjR4KP9JCRqSJnRq/Gk2aW0IVynTP5a0zQ1gI+xhwbV9OJc9btBvqGnJUiYmLDv2 fGfB6Rgx7ZDqhxQVTx/mhp8nsJ6IbbMBa4OzM3WzKz8K7OnVHyKcIXeIr85fZqRhTT/McslS0TZSi Fbz0+XOjvVvKkeAo0QXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1O4t-009ZoY-0p; Tue, 23 May 2023 09:13:11 +0000 Received: from mail-ej1-f41.google.com ([209.85.218.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1O4q-009Zmk-1f for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 09:13:10 +0000 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-970056276acso260950166b.2 for ; Tue, 23 May 2023 02:13:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684833185; x=1687425185; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e65v/JQ0YakfdpO5WAozFB3zrVj1i6YIZiY4qha6yIU=; b=gjhDtntEJYfcVH3lOHNbwZluAyt9at3bZGoHK0hzrioAvECeVyYDm36GZxQv5S5sqm 6hj4FfXDQOXRZzLD29LUau9bm2ykYGQJFxOGCLDuNtSNV5jslFokOdaMlJR74bO9rvqn v7W9BmfrtzebfmuEjc633BRa388zK/iL+BiFyIwgYzEzsT95Galv8LmFHUxvhdJuIq+R 2HmqC7+7fwFMFj81SjeqeGrMMH9sAwFRGcMBS9syR/ys17AR8jYaJRy0JyG58EyUVst7 DBxTkT7MeJXO9BXbMjEFNos0aGSAmGQtDNTE9ZS0vmSAdb/l6R+Why1n4kzVWc7g6gEu +7yA== X-Gm-Message-State: AC+VfDwxgMoD0oDDkYSQGdHD7SdGudyeUeU8AYrQmNt9/WaKObIGIV0E yFOsYcuDggiH4jemGt8VDlw= X-Google-Smtp-Source: ACHHUZ7RCSSHlTvlKn5S49Hw1Z7qGeq8+J1cF4YtJ4wYDQ+mU0uyNA3Z4JuVX1vTGl6Lc5SU2Hiv7Q== X-Received: by 2002:a17:907:9408:b0:965:6d21:48bc with SMTP id dk8-20020a170907940800b009656d2148bcmr11601570ejc.75.1684833184311; Tue, 23 May 2023 02:13:04 -0700 (PDT) Received: from [192.168.1.58] (185-219-167-24-static.vivo.cz. [185.219.167.24]) by smtp.gmail.com with ESMTPSA id h26-20020a17090634da00b0096f7e7d1566sm4147570ejb.224.2023.05.23.02.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 02:13:03 -0700 (PDT) Message-ID: <012b7c3d-1411-e5e1-662a-33369bfca610@kernel.org> Date: Tue, 23 May 2023 11:13:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Content-Language: en-US To: Herve Codina , Qiang Zhao , Li Yang , Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Mark Brown , Christophe Leroy , Thomas Petazzoni , kernel test robot References: <20230523085902.75837-1-herve.codina@bootlin.com> <20230523085902.75837-3-herve.codina@bootlin.com> From: Jiri Slaby In-Reply-To: <20230523085902.75837-3-herve.codina@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_021308_557165_ED48F981 X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23. 05. 23, 10:59, Herve Codina wrote: > In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from > the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is > set. > > Without this dependency, the linker fails with some missing symbols for > COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2. > > This lead to: > depends on CPM2 || CPM1 || (PPC32 && CPM2 && COMPILE_TEST) > > This dependency does not make sense anymore and can be simplified > removing all the COMPILE_TEST part. Then it's the same as my revert: https://lore.kernel.org/all/20230518055620.29957-1-jirislaby@kernel.org/ :D But nevermind. > Signed-off-by: Herve Codina > Reported-by: kernel test robot > Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/ > Fixes: e3e7b13bffae ("serial: allow COMPILE_TEST for some drivers") > --- > drivers/tty/serial/Kconfig | 2 +- > drivers/tty/serial/cpm_uart/cpm_uart.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 625358f44419..de092bc1289e 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -769,7 +769,7 @@ config SERIAL_PMACZILOG_CONSOLE > > config SERIAL_CPM > tristate "CPM SCC/SMC serial port support" > - depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST) > + depends on CPM2 || CPM1 > select SERIAL_CORE > help > This driver supports the SCC and SMC serial ports on Motorola > diff --git a/drivers/tty/serial/cpm_uart/cpm_uart.h b/drivers/tty/serial/cpm_uart/cpm_uart.h > index 0577618e78c0..46c03ed71c31 100644 > --- a/drivers/tty/serial/cpm_uart/cpm_uart.h > +++ b/drivers/tty/serial/cpm_uart/cpm_uart.h > @@ -19,8 +19,6 @@ struct gpio_desc; > #include "cpm_uart_cpm2.h" > #elif defined(CONFIG_CPM1) > #include "cpm_uart_cpm1.h" > -#elif defined(CONFIG_COMPILE_TEST) > -#include "cpm_uart_cpm2.h" > #endif > > #define SERIAL_CPM_MAJOR 204 -- js suse labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel