linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Date: Wed, 07 Jul 2010 08:29:38 +0900	[thread overview]
Message-ID: <013101cb1d63$1c8cd2f0$55a678d0$%kim@samsung.com> (raw)
In-Reply-To: <4C330916.1070201@ru.mvista.com>

Sergei Shtylyov wrote:

> 
> Hello.

Hi :-)
> 
> Kukjin Kim wrote:
> 
> > This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110.
> > Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB.
> > So each section's maximum size should be 16MB.
> 
> > Reported-by: Kyongho Cho <pullip.cho@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/include/mach/memory.h |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> > diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h
b/arch/arm/mach-
> s5pv210/include/mach/memory.h
> > index 379117e..4a372d8 100644
> > --- a/arch/arm/mach-s5pv210/include/mach/memory.h
> > +++ b/arch/arm/mach-s5pv210/include/mach/memory.h
> > @@ -16,8 +16,12 @@
> >  #define PHYS_OFFSET		UL(0x20000000)
> >  #define CONSISTENT_DMA_SIZE	(SZ_8M + SZ_4M + SZ_2M)
> >
> > -/* Maximum of 256MiB in one bank */
> > +/* Sparsemem support. Each section is a maximum of 16MB.
> > + * Because there are many different memory type on S5PC110(MCP),
> > + * and there is a case that having 80MB, 128MB or 256MB in one
> > + * bank.
> > +*/
> 
>     According to CodingStyle, the prefrerrable format for multi-line
comments
> is this:
> 
> /*
>   * bla
>   * bla
>   */
> 
Oh, ok..will modify.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

      reply	other threads:[~2010-07-06 23:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06  4:36 [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110 Kukjin Kim
2010-07-06  5:33 ` Kyungmin Park
2010-07-06 23:49   ` Kukjin Kim
2010-07-06  7:12 ` Russell King - ARM Linux
2010-07-06 23:27   ` Kukjin Kim
2010-07-07  2:15     ` Joonyoung Shim
2010-07-07  2:28       ` Kukjin Kim
2010-07-07  4:40     ` Kyungmin Park
2010-07-07  7:56     ` Russell King - ARM Linux
2010-07-08  0:01       ` Kukjin Kim
2010-07-08  8:02         ` Russell King - ARM Linux
2010-07-08 11:01           ` Kukjin Kim
2010-07-06 10:44 ` Sergei Shtylyov
2010-07-06 23:29   ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='013101cb1d63$1c8cd2f0$55a678d0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).