From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Diederik de Haas" <diederik@cknow-tech.com>,
"Maud Spierings" <maud_spierings@hotmail.com>
Subject: Re: [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector
Date: Tue, 28 Apr 2026 17:10:43 +0300 [thread overview]
Message-ID: <0143075a-098e-4275-b152-419700e4b7c0@collabora.com> (raw)
In-Reply-To: <xwsnwqk2bqixswue7ajy5tfzxn6u7sfuqlpquywsrdj3bs6nmb@pv6szzdjjuzu>
On 4/28/26 4:53 AM, Dmitry Baryshkov wrote:
> On Sun, Apr 26, 2026 at 03:20:22AM +0300, Cristian Ciocaltea wrote:
>> Switch from drm_helper_hpd_irq_event(), which polls all connectors, to
>> drm_connector_helper_hpd_irq_event(), which runs the detect cycle only
>> on the affected connector.
>>
>> This avoids unnecessary work and redundant detect calls on unrelated
>> connectors.
>
> This also doesn't feel correct. The dw_hdmi_qp is a bridge. As such it
> should be using drm_bridge_hpd_notify() rather than any of the mentioned
> functions. Would it be better to add the a corresponding wrapper to the
> dw_hdmi_qp API and call one there?
Let me try that.
> Also consider implementing the
> .hpd_enable() and .hpd_disable() callbacks for the bridge, which would
> remove the necessity to call enable the IRQ in the bind function.
Ack.
Thanks,
Cristian
prev parent reply other threads:[~2026-04-28 14:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 0:20 [PATCH v5 00/10] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-04-26 0:20 ` [PATCH v5 01/10] drm/bridge: Remove redundant error check in drm_bridge_helper_reset_crtc() Cristian Ciocaltea
2026-04-27 21:46 ` Dmitry Baryshkov
2026-04-26 0:20 ` [PATCH v5 02/10] drm/bridge: Add detect_ctx hook and drm_bridge_detect_ctx() helper Cristian Ciocaltea
2026-04-27 11:00 ` Heiko Stuebner
2026-04-26 0:20 ` [PATCH v5 03/10] drm/bridge-connector: Use cached connector status in .get_modes() Cristian Ciocaltea
2026-04-27 21:52 ` Dmitry Baryshkov
2026-04-26 0:20 ` [PATCH v5 04/10] drm/bridge-connector: Switch to .detect_ctx() for connector detection Cristian Ciocaltea
2026-04-27 21:54 ` Dmitry Baryshkov
2026-04-26 0:20 ` [PATCH v5 05/10] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling and high TMDS clock ratio support Cristian Ciocaltea
2026-04-27 10:49 ` Heiko Stuebner
2026-04-27 16:39 ` Cristian Ciocaltea
2026-04-27 19:09 ` Heiko Stuebner
2026-04-27 19:10 ` Heiko Stuebner
2026-04-28 1:38 ` Dmitry Baryshkov
2026-04-28 13:51 ` Cristian Ciocaltea
2026-04-26 0:20 ` [PATCH v5 06/10] drm/bridge: dw-hdmi-qp: Rate limit i2c read error messages Cristian Ciocaltea
2026-04-27 10:41 ` Heiko Stuebner
2026-04-26 0:20 ` [PATCH v5 07/10] drm/rockchip: dw_hdmi_qp: Add missing newlines in dev_err_probe() messages Cristian Ciocaltea
2026-04-27 10:39 ` Heiko Stuebner
2026-04-28 1:40 ` Dmitry Baryshkov
2026-04-26 0:20 ` [PATCH v5 08/10] drm/rockchip: dw_hdmi_qp: Use local dev variable consistently in bind() Cristian Ciocaltea
2026-04-27 10:39 ` Heiko Stuebner
2026-04-26 0:20 ` [PATCH v5 09/10] drm/rockchip: dw_hdmi_qp: Register HPD IRQ after connector setup Cristian Ciocaltea
2026-04-28 1:41 ` Dmitry Baryshkov
2026-04-28 13:58 ` Cristian Ciocaltea
2026-04-26 0:20 ` [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector Cristian Ciocaltea
2026-04-28 1:53 ` Dmitry Baryshkov
2026-04-28 14:10 ` Cristian Ciocaltea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0143075a-098e-4275-b152-419700e4b7c0@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=diederik@cknow-tech.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maud_spierings@hotmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox