From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: SAMSUNG: Convert irq-uart to use new irq_ functions
Date: Fri, 03 Dec 2010 20:37:31 +0900 [thread overview]
Message-ID: <015601cb92de$7b6913b0$723b3b10$%kim@samsung.com> (raw)
In-Reply-To: <1290783085-20098-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Mark Brown wrote:
>
> Convert to the new irq_ versions of the IRQ operations. As well as
> the textual substituion of irq_data for the raw IRQ number we also
> convert the register base lookup to in s3c_irq_uart_base() to pick
> the irq_data up directly.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> arch/arm/plat-samsung/irq-uart.c | 36
++++++++++++++++++------------------
> 1 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/irq-uart.c b/arch/arm/plat-samsung/irq-
> uart.c
> index 4f8c102..da31d78 100644
> --- a/arch/arm/plat-samsung/irq-uart.c
> +++ b/arch/arm/plat-samsung/irq-uart.c
> @@ -28,9 +28,9 @@
> * are consecutive when looking up the interrupt in the demux routines.
> */
>
> -static inline void __iomem *s3c_irq_uart_base(unsigned int irq)
> +static inline void __iomem *s3c_irq_uart_base(struct irq_data *data)
> {
> - struct s3c_uart_irq *uirq = get_irq_chip_data(irq);
> + struct s3c_uart_irq *uirq = data->chip_data;
> return uirq->regs;
> }
>
> @@ -39,10 +39,10 @@ static inline unsigned int s3c_irq_uart_bit(unsigned
int
> irq)
> return irq & 3;
> }
>
> -static void s3c_irq_uart_mask(unsigned int irq)
> +static void s3c_irq_uart_mask(struct irq_data *data)
> {
> - void __iomem *regs = s3c_irq_uart_base(irq);
> - unsigned int bit = s3c_irq_uart_bit(irq);
> + void __iomem *regs = s3c_irq_uart_base(data);
> + unsigned int bit = s3c_irq_uart_bit(data->irq);
> u32 reg;
>
> reg = __raw_readl(regs + S3C64XX_UINTM);
> @@ -50,10 +50,10 @@ static void s3c_irq_uart_mask(unsigned int irq)
> __raw_writel(reg, regs + S3C64XX_UINTM);
> }
>
> -static void s3c_irq_uart_maskack(unsigned int irq)
> +static void s3c_irq_uart_maskack(struct irq_data *data)
> {
> - void __iomem *regs = s3c_irq_uart_base(irq);
> - unsigned int bit = s3c_irq_uart_bit(irq);
> + void __iomem *regs = s3c_irq_uart_base(data);
> + unsigned int bit = s3c_irq_uart_bit(data->irq);
> u32 reg;
>
> reg = __raw_readl(regs + S3C64XX_UINTM);
> @@ -62,10 +62,10 @@ static void s3c_irq_uart_maskack(unsigned int irq)
> __raw_writel(1 << bit, regs + S3C64XX_UINTP);
> }
>
> -static void s3c_irq_uart_unmask(unsigned int irq)
> +static void s3c_irq_uart_unmask(struct irq_data *data)
> {
> - void __iomem *regs = s3c_irq_uart_base(irq);
> - unsigned int bit = s3c_irq_uart_bit(irq);
> + void __iomem *regs = s3c_irq_uart_base(data);
> + unsigned int bit = s3c_irq_uart_bit(data->irq);
> u32 reg;
>
> reg = __raw_readl(regs + S3C64XX_UINTM);
> @@ -73,10 +73,10 @@ static void s3c_irq_uart_unmask(unsigned int irq)
> __raw_writel(reg, regs + S3C64XX_UINTM);
> }
>
> -static void s3c_irq_uart_ack(unsigned int irq)
> +static void s3c_irq_uart_ack(struct irq_data *data)
> {
> - void __iomem *regs = s3c_irq_uart_base(irq);
> - unsigned int bit = s3c_irq_uart_bit(irq);
> + void __iomem *regs = s3c_irq_uart_base(data);
> + unsigned int bit = s3c_irq_uart_bit(data->irq);
>
> __raw_writel(1 << bit, regs + S3C64XX_UINTP);
> }
> @@ -99,10 +99,10 @@ static void s3c_irq_demux_uart(unsigned int irq,
struct
> irq_desc *desc)
>
> static struct irq_chip s3c_irq_uart = {
> .name = "s3c-uart",
> - .mask = s3c_irq_uart_mask,
> - .unmask = s3c_irq_uart_unmask,
> - .mask_ack = s3c_irq_uart_maskack,
> - .ack = s3c_irq_uart_ack,
> + .irq_mask = s3c_irq_uart_mask,
> + .irq_unmask = s3c_irq_uart_unmask,
> + .irq_mask_ack = s3c_irq_uart_maskack,
> + .irq_ack = s3c_irq_uart_ack,
> };
>
> static void __init s3c_init_uart_irq(struct s3c_uart_irq *uirq)
> --
Looks ok to me...will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2010-12-03 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 14:51 [PATCH 1/2] ARM: SAMSUNG: Convert irq-uart to use new irq_ functions Mark Brown
2010-11-26 14:51 ` [PATCH 2/2] ARM: SAMSUNG: Convert irq-vic-timer to " Mark Brown
2010-12-03 11:38 ` Kukjin Kim
2010-12-03 11:37 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015601cb92de$7b6913b0$723b3b10$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).