From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Sander Speetjens <sander.speetjens@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
Stephen Boyd <sboyd@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] firmware: raspberrypi: Style cleanups and fix child device lifetime
Date: Fri, 13 Nov 2026 19:21:07 -0800 [thread overview]
Message-ID: <01568cee-cd7b-466b-8546-ff45f3a69056@broadcom.com> (raw)
In-Reply-To: <20261107-fix-raspberrypi-firmware-v2-0-5bfe605a5cc5@gmail.com>
On 11/7/2026 10:21 AM, Sander Speetjens wrote:
> This series does minor style cleanups in the Raspberry Pi firmware
> driver and fixes the lifetime handling of the hwmon and clock child
> devices.
>
> The first five patches address checkpatch warnings (missing blank lines
> after declarations, incorrect indentation, unnecessary braces, and
> undocumented memory barriers).
>
> The final patch moves the hwmon and clock platform device pointers from
> globals into struct rpi_firmware. This pairs their lifetime with the
> parent device and prevents leaks or incorrect unregistration if the
> driver is probed more than once. It also checks the return value of
> platform_device_register_data() so that an error pointer is never
> stored. Registration failures are not propagated because the child
> devices are optional.
>
> ---
> Changes in v2:
> - Move platform device pointers to rpi firmware struct
> - Link to v1: https://lore.kernel.org/r/20261107-fix-raspberrypi-firmware-v1-0-707362c710cd@gmail.com
>
> ---
> Sander Speetjens (6):
> firmware: raspberrypi: Add blank line after declaration in response_callback
> firmware: raspberrypi: Fix indentation of return statement
> firmware: raspberrypi: Add blank line after declaration in probe error path
> firmware: raspberrypi: Remove unnecessary braces in transaction helper
> firmware: raspberrypi: Document memory barriers in property list path
> firmware: raspberrypi: Store child devices in struct rpi_firmware
>
> drivers/firmware/raspberrypi.c | 61 ++++++++++++++++++++++++++----------------
> 1 file changed, 38 insertions(+), 23 deletions(-)
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261107-fix-raspberrypi-firmware-be9c602d6755
Discard those messages about patches being applied, I see there is a v3
which I will be taking instead.
--
Florian
prev parent reply other threads:[~2026-11-14 3:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 18:21 [PATCH v2 0/6] firmware: raspberrypi: Style cleanups and fix child device lifetime Sander Speetjens
2026-11-07 18:21 ` [PATCH v2 1/6] firmware: raspberrypi: Add blank line after declaration in response_callback Sander Speetjens
2026-11-14 3:14 ` Florian Fainelli
2026-11-07 18:21 ` [PATCH v2 2/6] firmware: raspberrypi: Fix indentation of return statement Sander Speetjens
2026-11-14 3:14 ` Florian Fainelli
2026-11-07 18:21 ` [PATCH v2 3/6] firmware: raspberrypi: Add blank line after declaration in probe error path Sander Speetjens
2026-11-14 3:14 ` Florian Fainelli
2026-11-07 18:21 ` [PATCH v2 4/6] firmware: raspberrypi: Remove unnecessary braces in transaction helper Sander Speetjens
2026-11-08 21:03 ` Stefan Wahren
2026-11-14 3:14 ` Florian Fainelli
2026-11-07 18:21 ` [PATCH v2 5/6] firmware: raspberrypi: Document memory barriers in property list path Sander Speetjens
2026-11-07 18:46 ` Manuel Ebner
2026-11-14 3:14 ` Florian Fainelli
2026-11-07 18:21 ` [PATCH v2 6/6] firmware: raspberrypi: Store child devices in struct rpi_firmware Sander Speetjens
2026-11-08 21:06 ` Stefan Wahren
2026-11-09 5:55 ` Sander Speetjens
2026-11-10 10:21 ` Stefan Wahren
2026-11-14 3:15 ` Florian Fainelli
2026-11-14 3:21 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01568cee-cd7b-466b-8546-ff45f3a69056@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=sander.speetjens@gmail.com \
--cc=sboyd@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox